[#40167] - Use icon exit for close buttons
- Fixed in Code Base
- 4 May 2023
- Medium
- Build: 4.3-dev
- # 40167
- Diff
- chmst:icon-exit
User tests: Successful: Unsuccessful:
Pull Request for Issue #40112 .
Summary of Changes
Replace the "close" icon ( X ) by an exit icon. The exit icon is used in many apps.
Testing Instructions
All toobars have the exit-icon on the close button.
Actual result BEFORE applying this Pull Request
see #40112
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
I think that the exit icon has a meaning: leave the screen and do nothing. The "x" has the meaning "delete" or "cancel"but does not say "leave".
My apologies I didnt look properly at the pr only at the reporting issue.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40167.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40167.
| Status | Pending | ⇒ | Ready to Commit |
r2c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40167.
So much better...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40167.
However I was thinking that this icon is often used to portray an 'exit' from an application or a logout. Hope this won't confuse some users.
However I was thinking that this icon is often used to portray an 'exit' from an application or a logout. Hope this won't confuse some users.
Hopefully ... in this case it is an exit from a screen and together with the text it should be clear. Maybe we should use the close button without icon.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40167.
I have tested this item
Sorry - reverting my successful test to unsuccessful as I didnt spot that the text didnt change as shown in he screenhot and remains as cancel
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40167.
| Status | Ready to Commit | ⇒ | Pending |
back to pending
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40167.
the text didnt change as shown in he screenhot and remains as cancel
But "close" would be wrong on this place, when one start creating an article and then decide to not save it, one is cancelling the action not closing it...
the text didnt change as shown in he screenhot and remains as cancel
But "close" would be wrong on this place, when one start creating an article and then decide to not save it, one is cancelling the action not closing it...
I agree but the test instructions show it as changed to Close in the expected behaviour
Sorry, was absent.
The testing instructions said "all toolbars" have the exit icon.
I have chosen one Toolbar as an example so that testers see an exit icon.
We have buttons with text 'close" and with text "cancel". I am not sure if this quite consistent, but this is not in scope of this PR. They all had the same "x" icon, now they all have the exit-icon.
but your screenshot shows "articles new" with the text "close"
and my screenshot shows "articles new" with the text "cancel"
/me confused
My apologies. I was playing with different texts on the buttons and got the wrong screenshot. This is the correct oen for article edit
On categories it is close
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40167.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-4.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40167.
| Labels |
Added:
?
bug
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-05-04 23:53:11 |
| Closed_By | ⇒ | obuisard |
Now the "Cancel" label in the articles and categories views are shown with "Close". That's why the system tests in 4.4 are failing. Is this intended?
If yes, then such a change should never be merged in a patch release.
Sorry @laoneo you are wrong. (If the system tests are failing then it is because the system test is wrong.
When you create a new article then the text has always been Cancel
When you edit an existing article then the text has always been Close
The only thing the pr did was to change the icon that went with the text.
When you click the "New" button on the 4.3-dev branch Then you will see that Close is shown and not cancel. This is different than on 4.3.1.
Dev
4.3.1
Will this be ported to J5? Because the question came up in german Joomla forum https://forum.joomla.de/thread/18151-datei-l%C3%B6schen-datei-schliessen/?postID=147003#post147003
The problem with this PR is that we now have multiple icons being used for the same thing. As we are giving the icon a semantic meaning so that people will recognise the icon and know what it does we should be consistent.