? ? PHP 8.x PR-4.4-dev Pending

User tests: Successful: 2 joomdonation, toivo Unsuccessful: 0

avatar laoneo
laoneo
14 Mar 2023

Summary of Changes

When no ordering parameter exists in the latest module configuration, then is the following deprecated warning displayed:

strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /libraries/vendor/joomla/utilities/src/ArrayHelper.php on line 368

Testing Instructions

  • Create some articles
  • Create a latest articles module
  • Delete the params value in the modules table for the newly created module
  • Open the front end

Actual result BEFORE applying this Pull Request

The deprecated warning mentioned before is displayed.

Expected result AFTER applying this Pull Request

No warning is displayed.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2023
Category Modules Front End JavaScript Unit Tests
avatar laoneo laoneo - open - 14 Mar 2023
avatar laoneo laoneo - change - 14 Mar 2023
Status New Pending
dfb459e 14 Mar 2023 avatar laoneo cs
avatar laoneo laoneo - change - 14 Mar 2023
Labels Added: ? PHP 8.x PR-4.4-dev
avatar laoneo
laoneo - comment - 14 Mar 2023

It's really an edge case, which I discovered while writing the test. It is fine to leave it in 4.4 as this will not happen when you normally use the module.

avatar toivo toivo - test_item - 17 Mar 2023 - Tested successfully
avatar toivo
toivo - comment - 17 Mar 2023

I have tested this item successfully on dfb459e

Tested successfully in Joomka 4.4.0-dev of 16 March.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40108.

avatar joomdonation joomdonation - test_item - 17 Mar 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 17 Mar 2023

I have tested this item successfully on dfb459e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40108.

avatar joomdonation joomdonation - change - 17 Mar 2023
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 17 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40108.

avatar MacJoom MacJoom - close - 18 Mar 2023
avatar MacJoom MacJoom - merge - 18 Mar 2023
avatar MacJoom MacJoom - change - 18 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-18 11:20:36
Closed_By MacJoom
Labels Added: ?

Add a Comment

Login with GitHub to post a comment