[#40108] - Default the ordering parameter in the latest articles module
- Fixed in Code Base
- 18 Mar 2023
- Medium
- Build: 4.4-dev
- # 40108
- Diff
- Digital-Peak:cypress/module/latest
User tests: Successful: 2 joomdonation, toivo Unsuccessful: 0
Summary of Changes
When no ordering parameter exists in the latest module configuration, then is the following deprecated warning displayed:
strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /libraries/vendor/joomla/utilities/src/ArrayHelper.php on line 368
Testing Instructions
- Create some articles
- Create a latest articles module
- Delete the params value in the modules table for the newly created module
- Open the front end
Actual result BEFORE applying this Pull Request
The deprecated warning mentioned before is displayed.
Expected result AFTER applying this Pull Request
No warning is displayed.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Modules Front End JavaScript Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
PHP 8.x
PR-4.4-dev
|
||
I have tested this item
Tested successfully in Joomka 4.4.0-dev of 16 March.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40108.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40108.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40108.
MacJoom
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-18 11:20:36 |
| Closed_By | ⇒ | MacJoom | |
| Labels |
Added:
?
|
||
It's really an edge case, which I discovered while writing the test. It is fine to leave it in 4.4 as this will not happen when you normally use the module.