Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#40066] - [4.4] Rebuild mod_footer with new Joomla 4 structure

? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar sandewt
sandewt
10 Mar 2023

Pull Request for Issue # .

Summary of Changes

Rebuild mod_footer with new Joomla 4 structure
See: testing Instructions

Testing Instructions

Just try to use it as usual.

Actual result BEFORE applying this Pull Request

Module works

Expected result AFTER applying this Pull Request

Module works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Related to #39931 (mod_custom). Thks @sergeytolkachyov and @joomdonation

[EDIT mod_footer system test #40114]

avatar joomla-cms-bot joomla-cms-bot - change - 10 Mar 2023
Category ⇒ Modules Front End
avatar sandewt sandewt - open - 10 Mar 2023
avatar sandewt sandewt - change - 10 Mar 2023
Status New ⇒ Pending
avatar sandewt sandewt - change - 10 Mar 2023
The description was changed
avatar sandewt sandewt - edited - 10 Mar 2023
avatar sandewt sandewt - change - 10 Mar 2023
The description was changed
avatar sandewt sandewt - edited - 10 Mar 2023
avatar sandewt sandewt - change - 10 Mar 2023
Labels Added: PR-4.3-dev
avatar laoneo
laoneo - comment - 10 Mar 2023

Can you guys rebase this and the other pr's which do convert the modules to service providers to the 4.4 branch?

avatar sandewt
sandewt - comment - 10 Mar 2023

Can you guys rebase this and the other pr's which do convert the modules to service providers to the 4.4 branch?

How can I convert this PR in an easy way?

avatar laoneo
laoneo - comment - 10 Mar 2023

Click on the edit button next to the title and then change the target branch.

avatar sandewt sandewt - change - 10 Mar 2023
Title
…
[4.3] Rebuild mod_footer with new Joomla 4 structure
[4.4] Rebuild mod_footer with new Joomla 4 structure
avatar sandewt sandewt - edited - 10 Mar 2023
avatar sandewt
sandewt - comment - 10 Mar 2023

Click on the edit button next to the title and then change the target branch.

Done.

Does the Build: 4.3-dev label change automatically in the Issue Tracker CMS ? Or can I change that in Build: 4.4-dev?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40066.
avatar laoneo
laoneo - comment - 10 Mar 2023

@Quy changed it. If you want to join the bug squad team, then you get the permissions to do that by your own.

avatar laoneo laoneo - change - 10 Mar 2023
Labels Added: PR-4.4-dev
Removed: PR-4.3-dev
avatar joomdonation joomdonation - test_item - 11 Mar 2023 - Tested successfully
avatar joomdonation
joomdonation - comment - 11 Mar 2023

I have tested this item ✅ successfully on 6a13879

Thanks for your work !

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40066.

avatar carlitorweb carlitorweb - test_item - 11 Mar 2023 - Tested successfully
avatar carlitorweb
carlitorweb - comment - 11 Mar 2023

I have tested this item ✅ successfully on 6a13879

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40066.

avatar richard67 richard67 - change - 11 Mar 2023
Build 4.3-dev ⇒ 4.4-dev
avatar richard67 richard67 - change - 11 Mar 2023
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 11 Mar 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40066.

avatar richard67
richard67 - comment - 12 Mar 2023

@laoneo Site note: For the deleted files list in script.php I will care like I do for the other branches.

avatar Quy Quy - change - 12 Mar 2023
Labels Added: ?
avatar sandewt sandewt - change - 14 Mar 2023
The description was changed
avatar sandewt sandewt - edited - 14 Mar 2023
avatar laoneo
laoneo - comment - 14 Mar 2023

Added a system test for the footer module in #40114. Now we see if the test succeeds here as well.

avatar laoneo laoneo - change - 22 Mar 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-03-22 10:19:33
Closed_By ⇒ laoneo
avatar laoneo laoneo - close - 22 Mar 2023
avatar laoneo laoneo - merge - 22 Mar 2023
avatar laoneo
laoneo - comment - 22 Mar 2023

Thanks!

Add a Comment

Login with GitHub to post a comment