[#40054] - [4.3][Guided Tours] Administrator console unresponsive when CSS selector is invalid
- Fixed in Code Base
- 12 Mar 2023
- Medium
- Build: 4.3-dev
- # 40054
- Diff
- obuisard:guided-tours-error
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
When someone creating a tour enters a selector that is not valid, the tour does not start, produces an error in the browser console, nothing happens but the tour keeps trying to start until the user logs out. The user receives no feedback, unless he/her is aware of the browser console.
Summary of Changes
We already caught the error but the session storage was not cleared.
This PR clears the storage on error and produces an error message for the user.
Testing Instructions
Create a step or edit a step in a tour. Enter an invalid target, for instance #1_tada. This selector is invalid because it starts with a number.
Start the tour. you should see the error message:
Actual result BEFORE applying this Pull Request
The tour does not start, there is no user feedback and the user needs to logout to recover.
Expected result AFTER applying this Pull Request
The tour does not start, the administrator console is unaffected, a message pops up explaining that the tour cannot run and the user can resume activities.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings JavaScript Repository NPM Change Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-4.3-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40054.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40054.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40054.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-12 04:26:34 |
| Closed_By | ⇒ | obuisard |
I have tested this item✅ successfully on 99b66de
not a fan of the tone of the message but can confirm that it does what it says
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40054.