[#40044] - [4.3][Guided Tours] Editors should be accessible with tabs
- Fixed in Code Base
- 12 Mar 2023
- Medium
- Build: 4.3-dev
- # 40044
- Diff
- obuisard:guided-tours-editors
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Editors such as TinyMCE and JCE use iframes for editing content.
The script has been modified to be able to support step targets that are actually iframes.
Iframe elements cannot get 'blur' events so that event is passed on to the iframe's contentWindow.
It allows the tours to tab through the editor and the guided tour step without loosing focus.
Testing Instructions
Select TinyMCE or install and select the JCE Editor in the global configuration of your test site.
Start a tour, for instance, start the tour 'How to create categories'.
Step through the tour, up to the last step before the editor (the alias field).
Select 'Next'.
The step for the content editor will open.
Tab once gets you to the 'cancel' button.
Tab once or twice will get you to the editor (depending if content is already present in the editor).
Tab once will get you back into the modal, on the 'Next' button.
Shift tab will get you on the back button.
You can cycle through all of those elements with tab and shift tab.
Actual result BEFORE applying this Pull Request
The steps were tabbing through the content of TinyMCE only with a hack allowing the content to be added to the code source of the editor. JCE was not supported.
Expected result AFTER applying this Pull Request
TinyMCE and JCE are usable with guided tours without any hack.
Any iframe target used for any element will get proper events in the future.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql JavaScript Repository NPM Change Installation |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
@richard67 does this change need an update sql from beta3
I think yes.
@richard67 does this change need an update sql from beta3
I think yes.
;) it was my polite way of saying @obuisard please will you update this PR to provide an update sql from current to this
My apologies, I have added the necessary SQL for updates from beta 4.
I have tested this item
video coming
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40044.
As can be seen in the video (with captured keystrokes) the problem occurs when you tab out of the editor.
The script works under Firefox, fails with Chromium-enabled browsers.
Brian @brianteeman do you mind checking again? I would really appreciate. Thank you!
I have set a time out to catch the focus when leaving the editor.
Will test tomorrow as I don't use the computer on Saturday
I have tested this item
seems to work now. hope all these changes to the js dont conflict with each other
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40044.
hope all these changes to the js dont conflict with each other
They won't, I tested the whole thing together.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40044.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40044.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-12 03:56:20 |
| Closed_By | ⇒ | obuisard |
@richard67 does this change need an update sql from beta3