? PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
6 Mar 2023

This doesn't include any dependency updates to composer.json and package.json. These can be done separately by @HLeithner as the dependencies in 5.0 are generally a way ahead anyhow

avatar joomla-cms-bot joomla-cms-bot - change - 6 Mar 2023
Category Unit Tests Repository Administration com_admin SQL Postgresql
avatar wilsonge wilsonge - open - 6 Mar 2023
avatar wilsonge wilsonge - change - 6 Mar 2023
Status New Pending
avatar Hackwar
Hackwar - comment - 6 Mar 2023

.drone.yml still needs to be signed.

avatar wilsonge
wilsonge - comment - 6 Mar 2023

Are you able to do that? I haven't set up drone cli on my laptop (haven't sorted it out since I my old one broke at christmas)

avatar HLeithner HLeithner - change - 6 Mar 2023
Labels Added: ? PR-5.0-dev
avatar HLeithner
HLeithner - comment - 6 Mar 2023

signed it

avatar HLeithner
HLeithner - comment - 6 Mar 2023

@laoneo I have not the feeling that the --diff option for phpcs makes it easier to find the issue, at least I didn't found the problem in the current run...

avatar laoneo
laoneo - comment - 6 Mar 2023

Just run it locally without the dry run and then it will fix the issue automatically.

avatar wilsonge
wilsonge - comment - 6 Mar 2023

@laoneo I have not the feeling that the --diff option for phpcs makes it easier to find the issue, at least I didn't found the problem in the current run...

It's all just indentation fixes. I'll take a look later on today. I'll probably just use the tool like allon says. but not hard to fix by hand either

avatar HLeithner HLeithner - change - 7 Mar 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-07 18:11:40
Closed_By HLeithner
avatar HLeithner HLeithner - close - 7 Mar 2023
avatar HLeithner HLeithner - merge - 7 Mar 2023

Add a Comment

Login with GitHub to post a comment