? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
6 Mar 2023

Pull Request for Issue #40026 .

Summary of Changes

Set extensions field mandatory, so users must choose a component (or ALL)
Add a check in the store method in case of data import with empty extension field.

Testing Instructions

see #40026

Actual result BEFORE applying this Pull Request

Error message from the database

Expected result AFTER applying this Pull Request

Requested input on screen, a default value if the extension field is empty.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 6 Mar 2023
Category Administration
avatar chmst chmst - open - 6 Mar 2023
avatar chmst chmst - change - 6 Mar 2023
Status New Pending
avatar obuisard obuisard - change - 6 Mar 2023
Title
Tour Edit: Enforce value in extensions
[4.3] [Guided Tours] Tour Edit: Enforce value in extensions
avatar obuisard obuisard - edited - 6 Mar 2023
avatar obuisard obuisard - change - 6 Mar 2023
Title
[4.3] [Guided Tours] Tour Edit: Enforce value in extensions
[4.3][Guided Tours] Tour Edit: Enforce value in extensions
avatar obuisard obuisard - edited - 6 Mar 2023
avatar sdwjoomla sdwjoomla - test_item - 11 Mar 2023 - Tested successfully
avatar sdwjoomla
sdwjoomla - comment - 11 Mar 2023

I have tested this item successfully on 13729d6

Unable to save. Received error message and missing required field indicated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40034.

2023-03-10_18-34-35-PR40034-Test

avatar obuisard obuisard - test_item - 11 Mar 2023 - Tested successfully
avatar obuisard
obuisard - comment - 11 Mar 2023

I have tested this item successfully on 13729d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40034.

avatar khu5h1 khu5h1 - test_item - 11 Mar 2023 - Tested successfully
avatar khu5h1
khu5h1 - comment - 11 Mar 2023

I have tested this item successfully on 13729d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40034.

avatar obuisard obuisard - change - 11 Mar 2023
Labels Added: ? PR-4.3-dev
avatar obuisard obuisard - test_item - 11 Mar 2023 - Tested successfully
avatar obuisard
obuisard - comment - 11 Mar 2023

I have tested this item successfully on 5004c39


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40034.

avatar khu5h1 khu5h1 - test_item - 11 Mar 2023 - Tested successfully
avatar khu5h1
khu5h1 - comment - 11 Mar 2023

I have tested this item successfully on 5004c39


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40034.

avatar richard67 richard67 - change - 11 Mar 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 11 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40034.

avatar obuisard obuisard - change - 12 Mar 2023
Labels Added: ?
Removed: ?
avatar obuisard obuisard - close - 12 Mar 2023
avatar obuisard obuisard - merge - 12 Mar 2023
avatar obuisard obuisard - change - 12 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-12 04:43:50
Closed_By obuisard
avatar obuisard
obuisard - comment - 12 Mar 2023

Thank you Christiane @chmst for the PR!

Add a Comment

Login with GitHub to post a comment