? NPM Resource Changed bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
4 Mar 2023

Pull Request for Issue # .

Summary of Changes

  • Refactor the fallback code for the url/session initial path handling

Testing Instructions

  • test a url like (existing path) /administrator/index.php?option=com_media&path=local-images:/banners
  • test a url like (not existing path) /administrator/index.php?option=com_media&path=local-none:/banners
  • test a url like (not existing path) /administrator/index.php?option=com_media&path=local-none:/noooooo
  • Open the browser console and edit the session value from something like: {"selectedDirectory":"local-images:/banners","showInfoBar":false,"listView":"grid","gridSize":"md","search":"","sortBy":"name","sortDirection":"asc"} to values matching the changes on the previous steps (eg "selectedDirectory":"local-none:/banners", "selectedDirectory":"local-none:/noooooo") and check if the media manager loads without an error
  • Apply all possible combos between the url and the session storage

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo could you review this one?

avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2023
Category JavaScript Administration com_media NPM Change
avatar dgrammatiko dgrammatiko - open - 4 Mar 2023
avatar dgrammatiko dgrammatiko - change - 4 Mar 2023
Status New Pending
avatar dgrammatiko dgrammatiko - change - 4 Mar 2023
Labels Added: NPM Resource Changed PR-4.3-dev
eb90382 4 Mar 2023 avatar dgrammatiko nope
avatar viocassel viocassel - test_item - 22 Mar 2023 - Tested successfully
avatar viocassel
viocassel - comment - 22 Mar 2023

I have tested this item successfully on eb90382


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40013.

avatar dgrammatiko dgrammatiko - change - 6 May 2023
Labels Added: Feature
avatar laoneo laoneo - test_item - 8 May 2023 - Tested successfully
avatar laoneo
laoneo - comment - 8 May 2023

I have tested this item successfully on 239b06d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40013.

avatar laoneo laoneo - change - 8 May 2023
Status Pending Ready to Commit
avatar laoneo
laoneo - comment - 8 May 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40013.

avatar HLeithner
HLeithner - comment - 8 May 2023

This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.

avatar dgrammatiko
dgrammatiko - comment - 8 May 2023

@HLeithner this is a bug fix, nothing new introduced here, so it should be on 4.3

avatar HLeithner
HLeithner - comment - 8 May 2023

@Hackwar marked this as feature, my script filtered for the label and moved the pr.
@laoneo and @obuisard can you check and rebase if needed please

avatar laoneo
laoneo - comment - 8 May 2023

Changed it back as it had a wrong label. Would love to see it in the next release.

avatar obuisard obuisard - change - 8 May 2023
Labels Added: ? bug
Removed: Feature
avatar obuisard obuisard - change - 8 May 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-05-08 17:05:27
Closed_By obuisard
avatar obuisard obuisard - close - 8 May 2023
avatar obuisard obuisard - merge - 8 May 2023
avatar obuisard
obuisard - comment - 8 May 2023

Thank you Dimitris @dgrammatiko !

Add a Comment

Login with GitHub to post a comment