Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39973] - Improve Finder ajax error handling

? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
1 Mar 2023

Pull Request for Issue #39717 and #39965 .

Summary of Changes

Catch broken json and show an error message.
For Finder indexer, and for Finder autocomplete.

Testing Instructions

Apply patch, run npm install.

  1. Repeat test from #39965
    Go to a finder plugin, for example /plugins/finder/content/src/Extension/Content.php and trigger any output in the index() method. For example you can add var_dump($item->title).
    In the Smart Search component in the backend click on "Index".

  2. And similar for Autocomplete.
    Add var_dump(['error']) somewhere here

    joomla-cms/components/com_finder/src/Controller/SuggestionsController.php

    Lines 34 to 38 in 10f250f

    public function suggest()
    {
    $app = $this->app;
    $app->mimeType = 'application/json';

    Make sure autocomplete is enabled, then go to site search page, and try to search something.

Actual result BEFORE applying this Pull Request

The ajax stops without any visible signs of life.

Expected result AFTER applying this Pull Request

You should get an error message.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 1 Mar 2023
Category ⇒ Administration com_finder JavaScript Repository NPM Change Front End Modules
avatar Fedik Fedik - open - 1 Mar 2023
avatar Fedik Fedik - change - 1 Mar 2023
Status New ⇒ Pending
5d37ee4 1 Mar 2023 avatar Fedik jscs
avatar Fedik Fedik - change - 1 Mar 2023
Labels Added: NPM Resource Changed ?
avatar chmst
chmst - comment - 3 Mar 2023

I am confused .. @Fedik this is for 4.2 while @Hackwar has a PR for 4.3.

I have tested this PR on a 4.2 multilingual with blog sample data. But the output freezes without error message.
Need to find out why the npm ci did not do the job on the dev branch.

Repeated the test with the prebuild package and got a message

grafik

avatar chmst chmst - test_item - 3 Mar 2023 - Tested successfully
avatar chmst
chmst - comment - 3 Mar 2023

I have tested this item ✅ successfully on 5d37ee4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39973.

avatar Quy Quy - test_item - 3 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 3 Mar 2023

I have tested this item ✅ successfully on 5d37ee4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39973.

avatar Quy Quy - change - 3 Mar 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 3 Mar 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39973.

avatar roland-d roland-d - change - 6 Mar 2023
Labels Added: ?
avatar roland-d roland-d - change - 6 Mar 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-03-06 21:20:30
Closed_By ⇒ roland-d
avatar roland-d roland-d - close - 6 Mar 2023
avatar roland-d roland-d - merge - 6 Mar 2023
avatar roland-d
roland-d - comment - 6 Mar 2023

Thank you

Add a Comment

Login with GitHub to post a comment