[#39970] - [4.3] Fix drag & drop extension install
- Closed
- 12 Mar 2023
- Medium
- Build: 4.2-dev
- # 39970
- Diff
- wilsonge:fix_install
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #39969 .
Summary of Changes
Fixes package installs. Very unsure about this. In the frontend not sure we can really guarentee urls will looks like this (they might be sef'd up and not starting with a slash or index.php) we might well be better off reverting the original // cc @dgrammatiko
Testing Instructions
See linked issue
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin SQL Postgresql |
| Status | New | ⇒ | Pending |
| Category | Unit Tests Repository Administration com_admin SQL Postgresql | ⇒ | JavaScript Repository NPM Change |
hmhm, then better check for http, kind of:
(
token
&&
(
(!newOptions.url.startsWith('http:') && !newOptions.url.startsWith('https:'))
||
newOptions.url.startsWith(location.origin)
)
)
(If the url does not have http(s), or it startsWith(location.origin))
Need to test.
| Title |
|
||||||
Just make it :)
obuisard
- | Labels |
Added:
Release Blocker
NPM Resource Changed
PR-4.3-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-12 12:26:46 |
| Closed_By | ⇒ | obuisard |
Sorry but this doesnt fix the reported issue