[#39968] - PHP polyfills as explicit dependency
- Fixed in Code Base
- 13 Mar 2023
- Medium
- Build: 4.2-dev
- # 39968
- Diff
- Fedik:php-polifil
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #39954
Summary of Changes
Added symfony/polyfill-php80 and symfony/polyfill-php81 to composer json.
They already was in requirements, but implicitly.
Testing Instructions
Apply patch, run composer install, make sure all works as before.
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Composer Dependency Changed
?
|
||
can we pin this to the exact version please, then we don't have any changes to joomla it self (the changes in the lib are only codestyle and readme update, so no relevant code changes).
in 4.3 we already use the latest version so nothing needs to be changed in this branch.
I tried exact version, but composer complain that it do not see symfony/polyfill-php81 in lock file, or dron fail.
So I have no idea, and just updated these two
If there is a polyfill for 7.3, 8.0 and 8.1, is there also one for 7.4?
Yes there is https://github.com/symfony/polyfill-php74
But I do not think that we use any of these 3 methods
Maybe I better move it to 4.3, or?
@roland-d and @fancyFranci this is missing for 4.2.9
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-13 18:18:44 |
| Closed_By | ⇒ | fancyFranci |
Thanks! :)
drone failed