? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar korenevskiy
korenevskiy
27 Feb 2023

If you are in the plugin TinyeMCE settings, select a subdirectory for saving images. Then when you drag the image into the article editor, the image will not be saved to the selected user subdirectory, but will be saved as before to the parent /images directory.
But now the images will be saved to the selected user under the directory in the /images directory.

Before POST/GET request

option: com_media
format: json
url: 1
task: api.files
path: local-images:

content: "imageData"
name: "____Image.jpg"
parent: "publicacations_2023"

After Fix POST/GET request

option: com_media
format: json
url: 1
task: api.files
path: local-images:publications_2023

content: "imageData"
name: "____Image.jpg"
parent: "publicacations_2023"

The problem of saving the image to a subdirectory was in the absence of the name of the subdirectory in the path: parameter.
Because it is in the component that the images are saved to the subdirectory that is specified in the path: parameter of the POST request.
administrator/components/com_media/src/Controller/ApiController.php
In method ApiController->getPath()

Can you tell me if this PR needed to be added to [4.3-dev]?

avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2023
Category JavaScript Repository NPM Change
avatar korenevskiy korenevskiy - open - 27 Feb 2023
avatar korenevskiy korenevskiy - change - 27 Feb 2023
Status New Pending
avatar korenevskiy korenevskiy - change - 27 Feb 2023
Labels Added: NPM Resource Changed ?
avatar korenevskiy korenevskiy - change - 27 Feb 2023
Title
[pleTinyMCE] Error correction. Now you can drag and drop images into the material so that the image is saved to a custom folder.
[plgTinyMCE] Error correction. Now you can drag and drop images into the material so that the image is saved to a custom folder.
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar korenevskiy korenevskiy - change - 27 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar korenevskiy korenevskiy - change - 27 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar korenevskiy korenevskiy - change - 27 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar korenevskiy korenevskiy - change - 27 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar korenevskiy korenevskiy - change - 27 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar korenevskiy korenevskiy - change - 27 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar korenevskiy korenevskiy - change - 27 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar korenevskiy korenevskiy - change - 27 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar korenevskiy korenevskiy - change - 27 Feb 2023
Title
[plgTinyMCE] Error correction. Now you can drag and drop images into the material so that the image is saved to a custom folder.
[plgTinyMCE] Error correction. Now you can drag and drop images into the material so that the image is saved to a custom directory.
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar Quy
Quy - comment - 27 Feb 2023

Please close #39946 if this PR is for it.

avatar korenevskiy
korenevskiy - comment - 27 Feb 2023

Please close #39946 if this PR is for it.

No, this is a completely different problem.

avatar korenevskiy
korenevskiy - comment - 27 Feb 2023

@Quy @Fedik
Please tell me the file media/plg_editors_tinymce/js/plugins/dragdrop/plugin.js in the repository corresponds to the CMS file build/media_source/plg_editors_tinymce/js/plugins/dragdrop/plugin.es5.js?
Can you tell me if this PR needed to be added to [4.3-dev]?

avatar korenevskiy korenevskiy - change - 27 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar korenevskiy korenevskiy - change - 27 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar brianteeman
brianteeman - comment - 27 Feb 2023

There are two different issues here

  1. bug - fixes the path for drag and drop
  2. new feature - adds the context

Please seperate this into seperate pull requests. The bug fix is absolutely needed. I am not sure about the new feature

avatar korenevskiy korenevskiy - change - 27 Feb 2023
The description was changed
avatar korenevskiy korenevskiy - edited - 27 Feb 2023
avatar richard67
richard67 - comment - 27 Feb 2023

As this PR here fixes a bug, it is ok for 4.2-dev as it is.

avatar korenevskiy
korenevskiy - comment - 27 Feb 2023

Please seperate this into seperate pull requests. The bug fix is absolutely needed. I am not sure about the new feature

I divided it.

avatar Quy Quy - test_item - 1 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 1 Mar 2023

I have tested this item successfully on fdad2f4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39957.

avatar viocassel viocassel - test_item - 2 Mar 2023 - Tested successfully
avatar viocassel
viocassel - comment - 2 Mar 2023

I have tested this item successfully on fdad2f4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39957.

avatar alikon alikon - change - 2 Mar 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 2 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39957.

avatar roland-d roland-d - change - 6 Mar 2023
Labels Added: ?
avatar roland-d roland-d - change - 6 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-06 22:05:22
Closed_By roland-d
avatar roland-d roland-d - close - 6 Mar 2023
avatar roland-d roland-d - merge - 6 Mar 2023
avatar roland-d
roland-d - comment - 6 Mar 2023

Thank you

Add a Comment

Login with GitHub to post a comment