? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
25 Feb 2023

Pull Request for Issue # .

Summary of Changes

In Smart Search you can disable entries in the index by unpublishing them. Unfortunately, the entries were re-published when an item was saved again. I earlier claimed that it wasn't possible to prevent that behavior in our current system because I thought the state of the content item and the state of the item in the index were the same field in the database. I was wrong and we actually have a field named "published" for the state of the item in the index and "state" for the state item of the content item. Sorry, @brianteeman 😉 (Maybe you can help me find the issue where this was reported? I can't find it right now...)

After some debugging it turned out that in our finder plugins we are using the reindex() method of the Adapter class in finder and that method falsely completely deletes the entry first from the index and then adds it back in again. This actually is far less performant than simply indexing again as the normal indexer does...

Testing Instructions

Index your content and unpublish an entry in the index. Edit the content and without changing anything, save it again.

Actual result BEFORE applying this Pull Request

The item in the index is published again.

Expected result AFTER applying this Pull Request

The item stays unpublished until you publish it again.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2023
Category Administration com_finder
avatar Hackwar Hackwar - open - 25 Feb 2023
avatar Hackwar Hackwar - change - 25 Feb 2023
Status New Pending
avatar ChristineWk
ChristineWk - comment - 25 Feb 2023

I'm not sure, I don't know much about smart search, maybe this? #36980


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39944.

avatar Hackwar
Hackwar - comment - 25 Feb 2023

Unfortunately that issue is not the one I was looking for.

avatar fabpacheco
fabpacheco - comment - 25 Feb 2023

Or maybe #32458

avatar toivo toivo - test_item - 26 Feb 2023 - Tested successfully
avatar toivo
toivo - comment - 26 Feb 2023

I have tested this item ✅ successfully on 5a66c06

Tested successfully in Joomla 4.3.0-beta4 of 25 February using PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39944.

avatar brianteeman
brianteeman - comment - 26 Feb 2023

This one #38838 ?

avatar Hackwar
Hackwar - comment - 27 Feb 2023

Unfortunately none of these. I'm going to look further. But the issue of #38838 is very similar.

avatar brianteeman
brianteeman - comment - 27 Feb 2023

OK - this time I am sure I found it #36980

avatar Hackwar
Hackwar - comment - 27 Feb 2023

That one is related to the taxonomies, which I'm still working on.

avatar Quy Quy - test_item - 4 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 4 Mar 2023

I have tested this item ✅ successfully on 5a66c06


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39944.

avatar Quy Quy - change - 4 Mar 2023
Status Pending Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 4 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39944.

avatar obuisard obuisard - change - 4 Mar 2023
Labels Added: ?
avatar obuisard obuisard - close - 4 Mar 2023
avatar obuisard obuisard - merge - 4 Mar 2023
avatar obuisard obuisard - change - 4 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-04 15:24:09
Closed_By obuisard
avatar obuisard
obuisard - comment - 4 Mar 2023

Thank you Hannes @Hackwar !

Add a Comment

Login with GitHub to post a comment