? ? Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
25 Feb 2023

Summary of Changes

The link for the VCF file for a contact is wrong.

Testing Instructions

Go to the contact component and enable showing the VCF link to a contact. Click on that link in the frontend.

Actual result BEFORE applying this Pull Request

You get a 404.

Expected result AFTER applying this Pull Request

You get the correct file.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2023
Category Front End com_contact
avatar Hackwar Hackwar - open - 25 Feb 2023
avatar Hackwar Hackwar - change - 25 Feb 2023
Status New Pending
avatar Hackwar Hackwar - change - 25 Feb 2023
Labels Added: ?
avatar toivo toivo - test_item - 26 Feb 2023 - Tested unsuccessfully
avatar toivo
toivo - comment - 26 Feb 2023

I have tested this item ? unsuccessfully on a18f861

The link to the vCard worked every time with or without this PR, as show below.
Using Joomla 4.2.9-dev of 26 February and PHP 8.1.10 in Wampserver.

SEF URLs and URL rewriting enabled
before PR: http://joomla4test/contact?format=vcf
after PR: http://joomla4test/contact?format=vcf

SEF URLs and URL rewriting not selected
before PR: http://joomla4test/index.php?option=com_contact&view=contact&id=1&format=vcf&Itemid=150
after PR: http://joomla4test/index.php?option=com_contact&view=contact&catid=9:webmasters&id=1:toivo&format=vcf&Itemid=150


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938.
avatar Hackwar
Hackwar - comment - 27 Feb 2023

I'm sorry, I was a bit in a rush when I wrote all of this. The URL can be right by accident, however it fails when you have a menu item to a category of contacts and the contact is in a child category of that first category.

avatar toivo toivo - test_item - 2 Mar 2023 - Tested successfully
avatar toivo
toivo - comment - 2 Mar 2023

I have tested this item successfully on a18f861

@Hackwar, thank you for the detailed description.
Tested successfully in Joomla 4.2.9-dev of 2 March in PHP 8.1.10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938.

avatar Quy Quy - test_item - 2 Mar 2023 - Tested successfully
avatar Quy
Quy - comment - 2 Mar 2023

I have tested this item successfully on a18f861


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938.

avatar Quy Quy - change - 2 Mar 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 2 Mar 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39938.

avatar Quy Quy - change - 2 Mar 2023
Labels Added: ?
avatar fancyFranci fancyFranci - change - 4 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-04 16:36:30
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 4 Mar 2023
avatar fancyFranci fancyFranci - merge - 4 Mar 2023
avatar fancyFranci
fancyFranci - comment - 4 Mar 2023

Thank you!

avatar nielsnuebel
nielsnuebel - comment - 6 Mar 2023

@Hackwar Thanks for fixing my Discover bug at JoomlaCamp ?. I was also able to test successfully

Add a Comment

Login with GitHub to post a comment