? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
25 Feb 2023

Pull Request for Issue #39925.

Summary of Changes

#__banners.clickurl changed to varchar(2048)

Testing Instructions

insert a long url > 200 char and less than 2048 on "Click URL" field

Actual result BEFORE applying this Pull Request

On save you'll get an error: Data too long for column 'clickurl' at

Expected result AFTER applying this Pull Request

no error

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2023
Category SQL Installation
avatar alikon alikon - open - 25 Feb 2023
avatar alikon alikon - change - 25 Feb 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2023
Category SQL Installation SQL Installation Postgresql
avatar alikon alikon - change - 25 Feb 2023
Labels Added: PR-4.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 25 Feb 2023
Category SQL Installation Postgresql SQL Administration com_admin Installation Postgresql
avatar alikon alikon - change - 25 Feb 2023
Title
clickurl
[4][sql] banners.clickurl varchar(2048)
avatar alikon alikon - edited - 25 Feb 2023
avatar alikon alikon - change - 25 Feb 2023
The description was changed
avatar alikon alikon - edited - 25 Feb 2023
avatar chmst chmst - test_item - 25 Feb 2023 - Tested successfully
avatar chmst
chmst - comment - 25 Feb 2023

I have tested this item successfully on 696e7f8

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39937.

avatar Quy Quy - test_item - 25 Feb 2023 - Tested successfully
avatar Quy
Quy - comment - 25 Feb 2023

I have tested this item successfully on 696e7f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39937.

avatar Quy Quy - change - 25 Feb 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 25 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39937.

avatar obuisard obuisard - change - 3 Mar 2023
Labels Added: ?
avatar obuisard obuisard - change - 3 Mar 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-03-03 03:18:23
Closed_By obuisard
avatar obuisard obuisard - close - 3 Mar 2023
avatar obuisard obuisard - merge - 3 Mar 2023
avatar obuisard
obuisard - comment - 3 Mar 2023

Thank you Nicola @alikon for the PR!

Add a Comment

Login with GitHub to post a comment