No Code Attached Yet bug
avatar sandewt
sandewt
24 Feb 2023

In the manifest .xml files I see the following:

With a capital: UTF

<?xml version="1.0" encoding="UTF-8"?>

or with a lowercase: utf

<?xml version="1.0" encoding="utf-8"?>

Proposal: choose a consistent notation.

Note: I don't know what the standard is.

avatar sandewt sandewt - open - 24 Feb 2023
avatar sandewt sandewt - change - 24 Feb 2023
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 24 Feb 2023
avatar Hackwar Hackwar - change - 24 Feb 2023
Labels Added: bug
avatar Hackwar Hackwar - labeled - 24 Feb 2023
avatar sandewt sandewt - change - 24 Feb 2023
Title
[4.2] Make the manifest url type encoding consistent
[4.2] Make the manifest file type encoding consistent
avatar sandewt sandewt - edited - 24 Feb 2023
avatar sandewt sandewt - change - 24 Feb 2023
The description was changed
avatar sandewt sandewt - edited - 24 Feb 2023
avatar joomdonation
joomdonation - comment - 24 Feb 2023

Base on several sources I found in the internet, both are allowed but UTF-8 is preferred. You can see examples on this XML Specification page uses UTF-8, too.

@sandewt If it is possible, please make a PR to change it.

avatar sandewt
sandewt - comment - 24 Feb 2023

If it is possible, please make a PR to change it.

@joomdonation

It concerns more than 500 files. Changing all these files manually is quite a job with a chance of errors. I assume it can also be done with git or something similar. Sorry, but I'm not familiar enough with that right now.

avatar joomdonation
joomdonation - comment - 24 Feb 2023

@sandewt Could be done by search and replace for the whole codebase. But let's wait to see if maintainers want to change it.

avatar charvimehradu
charvimehradu - comment - 24 Feb 2023

@sandewt @joomdonation I can make a PR for this. Do I need any particular permissions?

avatar joomdonation
joomdonation - comment - 24 Feb 2023

@charvimehradu No permissions is needed. You can make PR, then maintainers will decide if it will be merged. But if you don't want to waste time, maybe wait until there is decision made.

avatar sandewt
sandewt - comment - 24 Feb 2023

I can make a PR for this. Do I need any particular permissions?

Obviously, any help is appreciated. (But wait until there is a decision made.)

avatar richard67
richard67 - comment - 26 Feb 2023

Closing as having a pull request. Please test #39949 . Thanks in advance.

avatar richard67 richard67 - change - 26 Feb 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-02-26 10:15:46
Closed_By richard67
avatar richard67 richard67 - close - 26 Feb 2023

Add a Comment

Login with GitHub to post a comment