? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
24 Feb 2023

Pull Request for Issue # .

Summary of Changes

This PR add missing context variable in URL for com_fields after an action such as publish/un-publish fields and field groups. The missing context variable causes the parent menu item being closed (instead of stay open as expected) after admin doing certain action.

This is the replacement for original PR #37818. The code implemented in that PR is wrong, I suggested the change but look like the author too busy and he did not update it after months, so I decide to make this one to replace so that we can have this small issue fixed. See the original PR if you want to understand more about the issue which this PR solves.

Testing Instructions

  1. Login to administrator area of your site
  2. Access to Content -> Fields.
  3. Create a custom field (if you do not have any custom fields created before)
  4. Try to publish/unpublish that field
  5. Repeat steps above for Content -> Field Groups

Actual result BEFORE applying this Pull Request

After publish, un-publish selected fields, the Content menu item being closed. You had to click on Content again before you can access to Content -> Fields.

Same for Content -> Field Groups

Expected result AFTER applying this Pull Request

The Content menu item stays open as expected.

Link to documentations

Please select:

  • [] Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • [] Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2023
Category Administration com_fields
avatar joomdonation joomdonation - open - 24 Feb 2023
avatar joomdonation joomdonation - change - 24 Feb 2023
Status New Pending
avatar joomdonation joomdonation - change - 24 Feb 2023
Labels Added: ?
avatar Quy Quy - test_item - 25 Feb 2023 - Tested successfully
avatar Quy
Quy - comment - 25 Feb 2023

I have tested this item successfully on 2e92b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39926.

avatar alikon alikon - test_item - 26 Feb 2023 - Tested successfully
avatar alikon
alikon - comment - 26 Feb 2023

I have tested this item successfully on 2e92b88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39926.

avatar alikon alikon - change - 26 Feb 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 26 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39926.

avatar roland-d roland-d - change - 28 Feb 2023
Labels Added: ?
avatar roland-d roland-d - change - 28 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-28 15:35:17
Closed_By roland-d
avatar roland-d roland-d - close - 28 Feb 2023
avatar roland-d roland-d - merge - 28 Feb 2023
avatar roland-d
roland-d - comment - 28 Feb 2023

Thank you

Add a Comment

Login with GitHub to post a comment