@roland-d try this - removed the @ symbol

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33405&start=0

Didn't realize Travis had failed here...

Yeah what do you think of travis failing here? It's not a problem with the code per se - it feels more like test problems? I dunno.

My first thought is we're making that check too early since that method only expects IPv4 or IPv6 addresses, not domain names.

So do we just want better regex rather than this then? I was following up on the old PR which did this (pre travis).

Could you please update this PR for the current staging?
Thanks!

Hello @wilsonge

Thank you for your contribution.

The last comment here was on 28th February. So the question is, Is this issue/pull request still valid?
If the issue is still valid can you please rebase to the current staging or re-do the PR so we are able to test and merge.
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!

I have absolutely no clue by now xD This was a rehash of #724 we did at the issue tracker code sprint in manchester last year. As the code wasn't originally mine - I honestly can't remember what the aim of it was at this point. It may be valid still?

I think it is still valid as we are now using a PHP native function for checking an IP address. I will get it tested during the PBF tomorrow and see what comes out of it.

Without this patch the validation still returns true on invalid IPv4 adresses and always false for IPv6. The integrated PHP function fixed this problem. It returns false and shows a warning message for invalid adresses.

I added to the administrator/com_content/views/articles/tmpl/default.php this code

$result1 = JMailHelper::isEmailAddress("zzz@zzz.zz");
echo "Mail zzz@zzz.zz ($result1)\n";
$result11 = JMailHelper::isEmailAddress("zzz.zzz@zz.zz");
echo "Mail zzz.zzz@zz.zz ($result11)\n";
$result12 = JMailHelper::isEmailAddress("zzz@zzz.zzz.zzz.zz");
echo "Mail zzz@zzz.zzz.zzz.zz ($result12)\n";
$result2 = JMailHelper::isEmailAddress("zzzzz.zz");
echo "Mail zzzzzz.zz ($result2)\n";
$result3 = JMailHelper::isEmailAddress("zzz@.zz");
echo "Mail zzz@.zz ($result3)\n";
$result4 = JMailHelper::isEmailAddress("127.0.0.1");
echo "IPv4 127.0.0.1 ($result4)\n";
$result5 = JMailHelper::isEmailAddress("1.2.3.4.5");
echo "IPv4 1.2.3.4.5 ($result5)\n";
$result6 = JMailHelper::isEmailAddress("::1");
echo "IPv6 ::1 ($result6)\n";
$result7 = JMailHelper::isEmailAddress("2001:0db8:85a3:08d3:1319:8a2e:0370:7344");
echo "IPv6 2001:0db8:85a3:08d3:1319:8a2e:0370:7344 ($result7)\n";

before patch result1, result11, result12 is 1(true) other 0(false)
after patch result1, result11, result12 also produce an "Warning: inet_pton(): Unrecognized address zz.zz in C:\xampp\htdocs\bugtesting\libraries\joomla\mail\helper.php on line "

so i replaced zzz@zzz.zz in result1 with zzz@gmx.de which is an Mailprovider, but also the warning "Warning: inet_pton(): Unrecognized address gmx.de in C:\xampp\htdocs\bugtesting\libraries\joomla\mail\helper.php on line"

Patchtest unsuccsessful.
Having the same result as the previous poster @MPompejus
Left a screenshot below to see what happens.

Hello @wilsonge

Thank you for your contribution.

The last comment here was on 21st August. So the question is, Is this issue/pull request still valid?
if so please provide clear test instructions to be able to test / reproduce this issue.
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!

You were the one who told me it was still valid last time :p you tell me

@wilsonge It's valid but the unsuccessful tests must be investigated.

@wilsonge what is the ststus of this?

Closing. I don't have the time to look into this. If someone wants they can pick it up.