Language Change bug Small PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
19 Feb 2023

Pull Request for Issue #24291 .

Summary of Changes

added check as in #23704

Testing Instructions

com_config->Server change database name with invalid chars like ', /' for mysql and save
for postgresql databasae name must start with a letter, followed by alphanumeric characters

Actual result BEFORE applying this Pull Request

error message "Database connection test failed with the following error: 1049: Could not connect to"

Expected result AFTER applying this Pull Request

warning message "The database name is invalid. It must not contain the following characters: \ / "

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

59194a4 19 Feb 2023 avatar alikon $app
dea1cd1 19 Feb 2023 avatar alikon lang
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2023
Category Administration com_config Language & Strings
avatar alikon alikon - open - 19 Feb 2023
avatar alikon alikon - change - 19 Feb 2023
Status New Pending
avatar richard67 richard67 - change - 19 Feb 2023
Labels Added: Language Change PR-4.3-dev
avatar richard67
richard67 - comment - 19 Feb 2023

@alikon I've allowed myself to commit the PHPCS fixes.

avatar toivo toivo - test_item - 2 Mar 2023 - Tested successfully
avatar toivo
toivo - comment - 2 Mar 2023

I have tested this item successfully on 5589ecf

Tested successfully in Joomla 4.3.0-beta4-dev of 2 March in MySQL and Postgres databases


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39889.

avatar viocassel viocassel - test_item - 3 Mar 2023 - Tested successfully
avatar viocassel
viocassel - comment - 3 Mar 2023

I have tested this item successfully on 5589ecf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39889.

avatar alikon alikon - change - 3 Mar 2023
Labels Added: ? ?
avatar alikon alikon - change - 3 Mar 2023
Labels Removed: ?
avatar toivo toivo - test_item - 13 Mar 2023 - Tested successfully
avatar toivo
toivo - comment - 13 Mar 2023

I have tested this item successfully on 7bfc976

Tested in Joomla 4.3.0-beta5-dev of 13 March using PHP 8.1.10
The MySQL site reports / and \ but does not detect . (full stop].
The PostgreSQL site reported invalid format as described in the PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39889.

33968c0 1 Apr 2023 avatar alikon dot
avatar alikon alikon - change - 3 May 2023
Labels Added: bug
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 4.4-dev.

avatar alikon
alikon - comment - 10 Apr 2024

after more than 1 year

avatar alikon alikon - close - 10 Apr 2024
avatar alikon alikon - change - 10 Apr 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-04-10 06:52:01
Closed_By alikon
Labels Added: Small PR-4.4-dev
Removed: PR-4.3-dev ?

Add a Comment

Login with GitHub to post a comment