[#39881] - Fix deprecation warning (PHP 8.1+)
- Fixed in Code Base
- 17 Feb 2023
- Medium
- Build: 4.2-dev
- # 39881
- Diff
- janschoenherr:patch-6
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Fix deprecation warning with PHP 8.1+
Summary of Changes
If a replacement string is used, but no 'quicktask' is defined $params->get('menu-quicktask') will return null which triggers:
Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in administrator/components/com_menus/src/Helper/MenusHelper.php on line 894
Actual result BEFORE applying this Pull Request
deprecation warning with PHP 8.1+
Expected result AFTER applying this Pull Request
No deprecation warning with PHP 8.1+
Link to documentations
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Status | New | ⇒ | Pending |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39881.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39881.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-17 17:16:22 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
PHP 8.x
|
||
I have tested this item✅ successfully on 5587796
Code review !
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39881.