User tests: Successful: Unsuccessful:
Passing null to md5 is deprecated in 8.1
code review
Deprecated notice:
Deprecated: md5(): Passing null to parameter #1 ($string) of type string is deprecated in libraries/src/Document/Document.php on line 634
No notice
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
Category | ⇒ | Libraries |
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Updated, thank you @joomdonation
Labels |
Added:
?
PHP 8.x
?
|
I think I fixed the code style but the build was killed somehow?
I restarted it.
Thank you! Looks like it's good now.
I have tested this item
Code review.
This pull request has been automatically rebased to 4.3-dev.
Labels |
Added:
bug
Removed: ? |
We need just one more test, this is tiny. Can someone review it so it can be merged into the next release?
@crystalenka When you do a branch update, test counter in the issue tracker is reset, so you have to add back the test result with use of the issue tracker (button "Alter test"). Otherwise nobody will find it when filtering by "Has 2 test" or "Needs 1 test". I will do that for you now, but in future please avoid unnecessary branch updates.
Ah I just see the PR has been rebased, so it needs new tests anyway.
Labels |
Added:
PR-4.3-dev
Removed: ? |
@richard67 it has been rebased, but it's a very minor change (just ~3 lines of code). Hopefully it can be tested and merged soon.
We tested this fix in a 4.3.3 / PHP 8.1.21 build, the issue is actually on line 649 of Document.php for this build, and it looks great. FWIW
Labels |
Added:
?
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-28 18:19:44 |
Closed_By | ⇒ | obuisard | |
Labels |
Removed:
?
|
Thanks Crystal @crystalenka for the PR!
In case $content is null, we should not add it to _style array. I would early return in this case. So add the lines of code below to beginning of the method to prevent warning:
In the future (not sure if Joomla 5 is suitable), we should use string type for $content parameter so that we do not have to add ugly code like that.