Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39833] - [4.3] Media manager: add the missing lock component

? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
10 Feb 2023

Pull Request for Issue # .

Summary of Changes

  • Adds the missing tabs-lock component
  • Fixes accessibility issues on media manager modals

Testing Instructions

  • Apply the PR and run npm ci
  • Open the rename, create new folder, preview, get link and delete modals and check that the tab is locked inside the modal. That's it

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Side effect the codemirror is updated because of the ranges in the package.json

avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2023
Category ⇒ Administration com_media NPM Change Front End Plugins
avatar dgrammatiko dgrammatiko - open - 10 Feb 2023
avatar dgrammatiko dgrammatiko - change - 10 Feb 2023
Status New ⇒ Pending
avatar brianteeman
brianteeman - comment - 10 Feb 2023

I assume the codemirror changes are not part of this pr?

avatar dgrammatiko
dgrammatiko - comment - 10 Feb 2023

I assume the codemirror changes are not part of this pr?

Actually the lock already uses the 5.65.11

joomla-cms/package-lock.json

Lines 3152 to 3156 in 7f7e232

"node_modules/codemirror": {
"version": "5.65.11",
"resolved": "https://registry.npmjs.org/codemirror/-/codemirror-5.65.11.tgz",
"integrity": "sha512-Gp62g2eKSCHYt10axmGhKq3WoJSvVpvhXmowNq7pZdRVowwtvBR/hi2LSP5srtctKkRT33T6/n8Kv1UGp7JW4A=="
},
I just added the missing XML parts here. This is related to the allowed ranges in the package.json which leads to such inconsistencies (and most of the times they're unnoticed). Just switch to specific versions, whatever is written in the can (package.json) is getting installed!!!

avatar richard67
richard67 - comment - 11 Feb 2023

Hmm, the package lock shows also an update of skipto from 4.1.6 to 4.1.7. Ok for me, but not related to this PR and I'm not sure if ok regarding our rules for beta phase.

avatar dgrammatiko
dgrammatiko - comment - 11 Feb 2023

Hmm, the package lock shows also an update of the skipto plugin from 4.1.6 to 4.1.7

Richard, this is once again a problem deriving from the decision to use ranges in the versions when, for a project of this scale, the npm i and npm ci should return the SAME node_modules folder. FWIW the package.json has the correct version 4.1.7 https://github.com/joomla/joomla-cms/pull/39833/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R66 which for whatever reason was reflected wrongly in the lock file. The production team needs to set some rules on how and by whom the package-lock.json and the package.json could be modified. There are too many mistakes...

avatar richard67 richard67 - test_item - 11 Feb 2023 - Tested successfully
avatar richard67
richard67 - comment - 11 Feb 2023

I have tested this item ✅ successfully on 3a20429

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39833.

avatar viocassel viocassel - test_item - 11 Feb 2023 - Tested successfully
avatar viocassel
viocassel - comment - 11 Feb 2023

I have tested this item ✅ successfully on 3a20429

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39833.

avatar Quy Quy - change - 11 Feb 2023
Status Pending ⇒ Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 11 Feb 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39833.

avatar obuisard obuisard - change - 13 Feb 2023
Labels Added: ? NPM Resource Changed
avatar obuisard obuisard - close - 13 Feb 2023
avatar obuisard obuisard - merge - 13 Feb 2023
avatar obuisard obuisard - change - 13 Feb 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-02-13 04:56:26
Closed_By ⇒ obuisard
avatar obuisard
obuisard - comment - 13 Feb 2023

Thank you Dimitris @dgrammatiko for the PR!

Add a Comment

Login with GitHub to post a comment