? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
9 Feb 2023

Pull Request for Issue #39825 .

Summary of Changes

  • Ignore tables with a class 'columns-order-ignore'
  • Add the class columns-order-ignore to the diff table

Testing Instructions

Follow the issue instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman

avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2023
Category JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - open - 9 Feb 2023
avatar dgrammatiko dgrammatiko - change - 9 Feb 2023
Status New Pending
avatar dgrammatiko dgrammatiko - change - 9 Feb 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 9 Feb 2023
avatar dgrammatiko dgrammatiko - change - 9 Feb 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2023
Category JavaScript Repository NPM Change Administration com_templates JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 9 Feb 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 9 Feb 2023
avatar brianteeman brianteeman - test_item - 9 Feb 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 9 Feb 2023

I have tested this item successfully on 36035d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39828.

avatar brianteeman
brianteeman - comment - 9 Feb 2023

when merged I will add a note to the manual page here https://manual.joomla.org/docs/using-core-functions/table-columns

avatar Quy Quy - test_item - 9 Feb 2023 - Tested successfully
avatar Quy
Quy - comment - 9 Feb 2023

I have tested this item successfully on 36035d6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39828.

avatar Quy Quy - change - 9 Feb 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 9 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39828.

avatar dgrammatiko dgrammatiko - change - 9 Feb 2023
Labels Added: ?
avatar Quy Quy - alter_testresult - 9 Feb 2023 - brianteeman: Tested successfully
avatar Quy Quy - alter_testresult - 9 Feb 2023 - Quy: Tested successfully
avatar brianteeman
brianteeman - comment - 10 Feb 2023

documentation added joomla/Manual#83

avatar dgrammatiko
dgrammatiko - comment - 10 Feb 2023

Thanks Brian, I didn't know that this was actually documented

avatar brianteeman
brianteeman - comment - 10 Feb 2023

Thanks Brian, I didn't know that this was actually documented

I'm a good boy and did what I was asked to do

avatar obuisard obuisard - close - 11 Feb 2023
avatar obuisard obuisard - merge - 11 Feb 2023
avatar obuisard obuisard - change - 11 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-11 18:25:36
Closed_By obuisard
avatar obuisard
obuisard - comment - 11 Feb 2023

Thank you Dimitris @dgrammatiko !

Add a Comment

Login with GitHub to post a comment