Feeling Lucky
PR-4.3-dev
[#39801] - Typo in DEPLOY_VERSION preventing replacement
- Fixed in Code Base
- 6 Feb 2023
- Medium
- Build: 4.3-dev
- # 39801
- Diff
- obuisard:Typo-version-43
User tests: Successful: Unsuccessful:
DEPLOY_VERSION is not replaced because of typo.
Summary of Changes
Added a missing _
Testing Instructions
Build a new version and check the comment @SInCE of $linked.
Actual result BEFORE applying this Pull Request
DEPLOY_VERSION is not replaced once the version is built.
Expected result AFTER applying this Pull Request
DEPLOY_VERSION is replaced with the current version number.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-06 07:47:05 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
PR-4.3-dev
|
||
laoneo
- comment
- 6 Feb 2023
Thanks!
Should we not hardcode it with the correct value?