Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39800] - Typo in DEPLOY_VERSION preventing replacement

? Pending

User tests: Successful: Unsuccessful:

avatar obuisard
obuisard
5 Feb 2023

DEPLOY_VERSION is not replaced because of typo

Summary of Changes

Added a missing _

Testing Instructions

Build a new version and check the comment @SInCE of getMissingModuleLanguages().

Actual result BEFORE applying this Pull Request

DEPLOY_VERSION is not replaced once the version is built.

Expected result AFTER applying this Pull Request

DEPLOY_VERSION is replaced with the current version number.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 5 Feb 2023
Category ⇒ Administration com_menus
avatar obuisard obuisard - open - 5 Feb 2023
avatar obuisard obuisard - change - 5 Feb 2023
Status New ⇒ Pending
avatar obuisard obuisard - change - 5 Feb 2023
The description was changed
avatar obuisard obuisard - edited - 5 Feb 2023
avatar obuisard obuisard - change - 5 Feb 2023
The description was changed
avatar obuisard obuisard - edited - 5 Feb 2023
avatar laoneo
laoneo - comment - 5 Feb 2023

Should we not hardcode it with the correct value?

avatar laoneo
laoneo - comment - 6 Feb 2023

This one here should be changed to 4.2.0 as it was added in that version by #37612.

avatar wilsonge wilsonge - change - 6 Feb 2023
Labels Added: ?
avatar wilsonge wilsonge - change - 6 Feb 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-02-06 10:43:55
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 6 Feb 2023
avatar wilsonge wilsonge - merge - 6 Feb 2023

Add a Comment

Login with GitHub to post a comment