[#39785] - [4.2]Corrected different multi-select behavior in media manage
- Closed
- 8 Feb 2023
- Medium
- Build: 4.2-dev
- # 39785
- Diff
- rajputanuj31:multiselect
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Pull Request #33637
Summary of Changes
Multi select without using shift key
Testing Instructions
Open Media
Try to Select media manager files.
Actual result BEFORE applying this Pull Request
You can not select multiple items without holding the shift key.
Expected result AFTER applying this Pull Request
You can select multiple items by holding ctrl key & clicking on items.
You can also select all files between two selected files by holding shift key.
Media.-.Demo-.Trim.mp4
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
Besides this, the javascript linter at the drone CI tests reports errors here https://ci.joomla.org/joomla/joomla-cms/61584/1/26 :
+ npm run lint:js
> joomla@4.0.0 lint:js
> eslint --config build/.eslintrc --ignore-pattern '/media/' --ext .es6.js,.es6,.vue .
/********/src/administrator/components/com_media/resources/scripts/components/browser/items/item.es6.js
117:17 error 'event' is defined but never used no-unused-vars
/********/src/administrator/components/com_media/resources/scripts/components/browser/items/row.vue
96:13 error 'event' is defined but never used no-unused-vars
✖ 2 problems (2 errors, 0 warnings)
@rajputanuj31 I think the expected behaviour involves both
ctrlandshiftkeys, I had started fixing it here: #39679 (comment) (it needs theshiftkey logic as explained in that comment)
@dgrammatiko Is this looks fine??
Media.-Trim-2.mp4
| Labels |
Added:
NPM Resource Changed
?
|
||
@rajputanuj31 please rebase this pr to 4.3-dev
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-08 16:45:33 |
| Closed_By | ⇒ | rajputanuj31 |
@rajputanuj31 I think the expected behaviour involves both
ctrlandshiftkeys, I had started fixing it here: #39679 (comment) (it needs theshiftkey logic as explained in that comment)