? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
1 Feb 2023
  • Also intorduce the class js-select-reset-on-change that resets all the other filters except the target and submits the form

Pull Request for Issue #39726 .

Summary of Changes

  • Intorduces the class js-select-reset-on-change that resets all the other filters except the target and submits the form
  • Fix the functionality for selects that are outside of the container .js-stools-container-bar and have either a class js-select-reset-on-change or js-select-submit-on-change

Testing Instructions

Check the left most selects on the pages:

  • administrator/index.php?option=com_menus&view=menus
  • administrator/index.php?option=com_associations&view=associations
  • administrator/index.php?option=com_languages&view=installed and all the other com_menus views
  • administrator/index.php?option=com_modules&view=modules&client_id=0
  • administrator/index.php?option=com_modules&view=modules&client_id=1
  • administrator/index.php?option=com_templates&view=templates&client_id=0
  • administrator/index.php?option=com_templates&view=templates&client_id=1
  • administrator/index.php?option=com_templates&view=styles&client_id=0
  • administrator/index.php?option=com_templates&view=styles&client_id=1

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy

avatar joomla-cms-bot joomla-cms-bot - change - 1 Feb 2023
Category Administration com_associations com_languages com_menus com_modules com_templates JavaScript Repository NPM Change
avatar dgrammatiko dgrammatiko - open - 1 Feb 2023
avatar dgrammatiko dgrammatiko - change - 1 Feb 2023
Status New Pending
avatar Quy Quy - test_item - 1 Feb 2023 - Tested successfully
avatar Quy
Quy - comment - 1 Feb 2023

I have tested this item successfully on 2c94343

THANK YOU!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39772.

avatar viocassel viocassel - test_item - 2 Feb 2023 - Tested successfully
avatar viocassel
viocassel - comment - 2 Feb 2023

I have tested this item successfully on 2c94343


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39772.

avatar Quy Quy - change - 2 Feb 2023
Status Pending Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 2 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39772.

avatar Quy
Quy - comment - 2 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39772.

avatar Quy Quy - change - 2 Feb 2023
Labels Added: ?
avatar obuisard obuisard - close - 3 Feb 2023
avatar obuisard obuisard - merge - 3 Feb 2023
avatar obuisard obuisard - change - 3 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-03 04:54:01
Closed_By obuisard
Labels Added: NPM Resource Changed
avatar obuisard
obuisard - comment - 3 Feb 2023

Thank you Dimitris @dgrammatiko, great work!

Add a Comment

Login with GitHub to post a comment