? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar rajputanuj31
rajputanuj31
30 Jan 2023

Pull Request for Issue #31340

I am extremely sorry... Had to delete my previous PR due to my fault, won't happen again. Please do have a look.

Testing Instructions

Create a new folder in Media and open it (No files should be present)

Expected Result Before PR

No message

Expected Result After PR

A Drag and drop icon and a message will show and If you drag the file icon will highlight.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2023
Category Administration com_media NPM Change
avatar rajputanuj31 rajputanuj31 - open - 30 Jan 2023
avatar rajputanuj31 rajputanuj31 - change - 30 Jan 2023
Status New Pending
avatar rajputanuj31 rajputanuj31 - change - 30 Jan 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar Quy
Quy - comment - 30 Jan 2023

It is not vertically centered.

39749

avatar rajputanuj31 rajputanuj31 - change - 30 Jan 2023
The description was changed
avatar rajputanuj31 rajputanuj31 - edited - 30 Jan 2023
avatar rajputanuj31
rajputanuj31 - comment - 30 Jan 2023

It is not vertically centered.

39749

@Quy I made some more changes. please review it suggests some changes if needed. if everything looks ok then test it.
Thanks for your inputs.

avatar Quy
Quy - comment - 31 Jan 2023

39749-list-view

avatar dgrammatiko
dgrammatiko - comment - 31 Jan 2023

@rajputanuj31 to fix the problem @Quy reported apply this (L125):

height: this.$store.state.listView === 'table' && !this.isEmpty ? 'unset' : '100%',
avatar Quy Quy - test_item - 31 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 31 Jan 2023

I have tested this item successfully on 6cbf8ed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39749.

avatar viocassel viocassel - test_item - 31 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 31 Jan 2023

I have tested this item successfully on 6cbf8ed


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39749.

avatar Quy Quy - change - 31 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 31 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39749.

avatar obuisard obuisard - close - 1 Feb 2023
avatar obuisard obuisard - merge - 1 Feb 2023
avatar obuisard obuisard - change - 1 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-01 17:46:12
Closed_By obuisard
Labels Added: ?
avatar obuisard
obuisard - comment - 1 Feb 2023

Thank you @rajputanuj31 for the PR!

avatar rajputanuj31
rajputanuj31 - comment - 1 Feb 2023

thanks @Quy and @viocassel for tests.
Special thanks to @dgrammatiko for your guidance & support.

Add a Comment

Login with GitHub to post a comment