Feeling Lucky
?
?
[#39748] - [4.2] Highlight Plugin: Exit if app not site
- Fixed in Code Base
- 9 Feb 2023
- Medium
- Build: 4.2-dev
- # 39748
- Diff
- joomla:Hackwar-patch-1
- Pending continuous-integration/drone/push Build is running Details
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
User tests: Successful: Unsuccessful:
Summary of Changes
While doing some debugging, I stumbled upon this one. The comment itself says, that it should only act on the site application and nothing else. The code however only exits when in the administrator application. This could be a problem in the CLI or other application contexts.
Testing Instructions
Codereview.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
alikon
- comment
- 30 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39748.
Hackwar
- comment
- 30 Jan 2023
I'm sorry, that this is in the wrong branch.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 30 Jan 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39748.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-09 12:48:33 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 9 Feb 2023
Thanks!
I have tested this item✅ successfully on 36bad46
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39748.