? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
26 Jan 2023

I would appreciate it if the cypress.config.js could be customised. Since a database password might be inserted, it would be great if this file is not always included in the changed files in git, in case someone wants to create a PR.

64830b0 26 Jan 2023 avatar astridx wip
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2023
Category Repository JavaScript
avatar astridx astridx - open - 26 Jan 2023
avatar astridx astridx - change - 26 Jan 2023
Status New Pending
avatar dgrammatiko
dgrammatiko - comment - 26 Jan 2023

@astridx usually there's a dist file like https://github.com/joomla/joomla-cms/blob/4.3-dev/tests/Codeception/acceptance.suite.dist.yml but also this could work with couple of changes in the drone.yml

avatar astridx
astridx - comment - 26 Jan 2023

@astridx usually there's a dist file like https://github.com/joomla/joomla-cms/blob/4.3-dev/tests/Codeception/acceptance.suite.dist.yml but also this could work with couple of changes in the drone.yml

Yes, that's exactly why I renamed the cypress config here to a file that contains the text dist. Or am I understanding you wrong?

b33529c 26 Jan 2023 avatar astridx wip
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2023
Category Repository JavaScript Unit Tests Repository JavaScript
avatar astridx astridx - change - 26 Jan 2023
Labels Added: PR-4.3-dev
avatar laoneo laoneo - change - 28 Jan 2023
Labels Added: ?
avatar astridx astridx - change - 29 Jan 2023
The description was changed
avatar astridx astridx - edited - 29 Jan 2023
avatar laoneo
laoneo - comment - 31 Jan 2023

Can you fix the conflicts here?

avatar astridx
astridx - comment - 1 Feb 2023

Can you fix the conflicts here?

Fixed

avatar laoneo laoneo - close - 2 Feb 2023
avatar laoneo laoneo - merge - 2 Feb 2023
avatar laoneo laoneo - change - 2 Feb 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-02 10:32:04
Closed_By laoneo
avatar laoneo
laoneo - comment - 2 Feb 2023

Thanks!

avatar HLeithner
HLeithner - comment - 13 Feb 2023

btw. you can use environment variables to override the config options

Add a Comment

Login with GitHub to post a comment