? ? Pending

User tests: Successful: Unsuccessful:

avatar harsitagarwalla187
harsitagarwalla187
26 Jan 2023

Pull Request for Issue #39701.

Summary of Changes

Updated md5() from passing null to parameter.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2023
Category ⇒ Libraries
avatar harsitagarwalla187 harsitagarwalla187 - open - 26 Jan 2023
avatar harsitagarwalla187 harsitagarwalla187 - change - 26 Jan 2023
Status New ⇒ Pending
avatar harsitagarwalla187 harsitagarwalla187 - change - 26 Jan 2023
The description was changed
avatar harsitagarwalla187 harsitagarwalla187 - edited - 26 Jan 2023
avatar harsitagarwalla187 harsitagarwalla187 - change - 26 Jan 2023
The description was changed
avatar harsitagarwalla187 harsitagarwalla187 - edited - 26 Jan 2023
avatar laoneo
laoneo - comment - 27 Jan 2023

The second argument of md5 is a boolean and not a string. Why do you add a string here?

avatar harsitagarwalla187 harsitagarwalla187 - change - 27 Jan 2023
Labels Added: ?
avatar harsitagarwalla187
harsitagarwalla187 - comment - 30 Jan 2023

@alikon Please have a look. I have made the changes.

avatar laoneo laoneo - test_item - 31 Jan 2023 - Tested successfully
avatar laoneo
laoneo - comment - 31 Jan 2023

I have tested this item ✅ successfully on 633cc21

Tested with null as secret in configuration. Not sure how this can happen, but the fix works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39720.

avatar Quy Quy - test_item - 31 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 31 Jan 2023

I have tested this item ✅ successfully on 633cc21


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39720.

avatar Quy Quy - change - 31 Jan 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 31 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39720.

avatar laoneo laoneo - change - 31 Jan 2023
Labels Added: ?
avatar fancyFranci fancyFranci - close - 4 Feb 2023
avatar fancyFranci fancyFranci - merge - 4 Feb 2023
avatar fancyFranci fancyFranci - change - 4 Feb 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-02-04 09:57:05
Closed_By ⇒ fancyFranci
avatar fancyFranci
fancyFranci - comment - 4 Feb 2023

Thank you!

Add a Comment

Login with GitHub to post a comment