[#39719] - 4.3-alpha-4 notice in administrator\components\com_fields\src\Helper\FieldsHelper.php
- Closed
- 15 Feb 2023
- Medium
- Build: 4.2-dev
- # 39719
Steps to reproduce the issue
open a component's settings at admin backend
Actual result
got notice;
Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated
in ..\administrator\components\com_fields\src\Helper\FieldsHelper.php on line 59
I changed code at line 59 to:
if (empty($contextString))
$parts = array();
else
$parts = explode('.', $contextString, 2);
this fixed it.
System information (as much as possible)
4.3-apha4-dev
php 8.1.6
Additional comments
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
Quy
- | Labels |
Added:
PHP 8.x
|
||
hi,
I am not able to find out which component is causing this. But I think that any coding esp. in libraries should take care, if parameters or any other input is not set as expected- E.g. if your variable "$contextString" is expected to be an array you should check this and add code to handle wrong assignments.
Yes, we can take care of that, but it will make our codebase a bit ugly. Since you proposed code, could you please make a PR to address this issue ? I think we can just return early if null is passed for that parameter, something like:
if ($contextString === null) {
return null;
}| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-15 11:30:58 |
| Closed_By | ⇒ | joomdonation |
@jschmi102 Could you please let us know what component you are having this error :