? ? Pending

User tests: Successful: Unsuccessful:

avatar charvimehradu
charvimehradu
26 Jan 2023

Pull Request for Issue #38539 .

Summary of Changes

-Changed the nesting style and added the input tag outside of the label tag as done in the default_login.
-Added their id and for attributes to make sure they worked.
-Removed the id tag from the div tag as I had already inserted it in the label tag and also to show more uniformity.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Jan 2023
Category Modules Front End
avatar charvimehradu charvimehradu - open - 26 Jan 2023
avatar charvimehradu charvimehradu - change - 26 Jan 2023
Status New Pending
avatar charvimehradu charvimehradu - change - 26 Jan 2023
The description was changed
avatar charvimehradu charvimehradu - edited - 26 Jan 2023
avatar charvimehradu charvimehradu - change - 26 Jan 2023
The description was changed
avatar charvimehradu charvimehradu - edited - 26 Jan 2023
avatar charvimehradu charvimehradu - change - 28 Jan 2023
Labels Added: ?
avatar Fedik Fedik - test_item - 28 Jan 2023 - Tested successfully
avatar Fedik
Fedik - comment - 28 Jan 2023

I have tested this item successfully on 0efb3e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39715.

avatar viocassel viocassel - test_item - 29 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 29 Jan 2023

I have tested this item successfully on 0efb3e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39715.

avatar Quy Quy - change - 29 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39715.

avatar charvimehradu charvimehradu - change - 2 Feb 2023
Labels Added: ?
avatar fancyFranci fancyFranci - close - 4 Feb 2023
avatar fancyFranci fancyFranci - merge - 4 Feb 2023
avatar fancyFranci fancyFranci - change - 4 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-04 09:46:40
Closed_By fancyFranci
avatar fancyFranci
fancyFranci - comment - 4 Feb 2023

Finally its consistent! Thank you :)

avatar charvimehradu
charvimehradu - comment - 4 Feb 2023

Glad I could help!

Add a Comment

Login with GitHub to post a comment