Feeling Lucky
?
?
[#39714] - Update Version.php
- Fixed in Code Base
- 3 Feb 2023
- Medium
- Build: 4.2-dev
- # 39714
- Diff
- n3t:n3t-patch-1
User tests: Successful: Unsuccessful:
Cache LifeTime is in minutes, not seconds, 10 years value should be 5 259 600, not 315 576 000.
Summary of Changes
Change cache time to correct number,
Testing Instructions
PHP 7.4.4, 32bits (yeah, not proud of it, just terrible hosting), Memcached enabled
Actual result BEFORE applying this Pull Request
As cache time is multiplied by 60 in CacheStorage constructor, setting to 315 576 000 to 18 934 560 000,
which on 32bits PHP was converted to float, giving
PHP Warning: Memcached::set() expects parameter 3 to be int, float given in /libraries/src/Cache/Storage/MemcachedStorage.php on line 260
Expected result AFTER applying this Pull Request
No warning.
Additional info
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
alikon
- comment
- 28 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39714.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 28 Jan 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39714.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-03 20:44:12 |
| Closed_By | ⇒ | fancyFranci | |
| Labels |
Added:
?
|
||
fancyFranci
- comment
- 3 Feb 2023
Thank you very much
I have tested this item✅ successfully on 2c1379d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39714.