NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
25 Jan 2023

Pull Request for Issue # .

Summary of Changes

  • The configuration files for ESLint and StyleLint was placed inside the build folder (mainly because those were hidden files). Now both these tools allow the name.config.json convention so we can move them back to the root. The build.php was updated to exclude them from the packaging process.
  • Similarly, the settings for the localisation of node_modules and the creation of the error pages was also stored in a file named settings.json inside the build folder. The whole section is now in the package.json under the key joomlaSettings. All the scripts affected by this change were updated.
  • Finally a section before documentation was added to the PR template and looks like:
// Preview starts here

Codestyle conformance

Please make sure that proir to creating a Pull Request you have ran locally the following commands:

  • PHP: ./libraries/vendor/bin/phpcs --extensions=php -p --standard=ruleset.xml .
  • JS: npm run lint:js or for autofixing minor problems npm run lint:js -- --fix
  • SCSS/CSS: npm run lint:css or for autofixing minor problems npm run lint:css -- --fix
// Preview ends here

Testing Instructions

Test that all the commands in the package.json still work as expected.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Documented in the build/README.md

avatar joomla-cms-bot joomla-cms-bot - change - 25 Jan 2023
Category Repository JavaScript NPM Change
avatar dgrammatiko dgrammatiko - open - 25 Jan 2023
avatar dgrammatiko dgrammatiko - change - 25 Jan 2023
Status New Pending
avatar dgrammatiko dgrammatiko - change - 25 Jan 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar dgrammatiko dgrammatiko - change - 25 Jan 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 25 Jan 2023
avatar HLeithner
HLeithner - comment - 17 Feb 2023

can your solve the conflicts? @Fedik any objections?

8d47038 17 Feb 2023 avatar dgrammatiko json
avatar Fedik
Fedik - comment - 17 Feb 2023

No objections ;)

avatar dgrammatiko dgrammatiko - change - 6 Mar 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-03-06 16:59:55
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 6 Mar 2023

Add a Comment

Login with GitHub to post a comment