[#39709] - [4.3] Media Manger Remove all the eslint inline rule overrides
- Fixed in Code Base
- 27 Jan 2023
- Medium
- Build: 4.3-dev
- # 39709
- Diff
- dgrammatiko:4.3-dev-mm-lint
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
- Remove all the eslint rule overrides
- Change some imports/exports to default
- Add the missing props on many components
Also, and this one is important and the reason I did this PR, stop mutation store values outside of the store. The vue docs are very clear on this one: https://eslint.vuejs.org/rules/no-side-effects-in-computed-properties.html#rule-details
The instance that was wrongly mutating the store is:
/* Get the contents of the currently selected directory */
items() {
// eslint-disable-next-line vue/no-side-effects-in-computed-properties
const directories = this.$store.getters.getSelectedDirectoryDirectories
// Sort by type and alphabetically
.sort((a, b) => ((a.name.toUpperCase() < b.name.toUpperCase()) ? -1 : 1))
.filter((dir) => dir.name.toLowerCase().includes(this.$store.state.search.toLowerCase()));
// eslint-disable-next-line vue/no-side-effects-in-computed-properties
const files = this.$store.getters.getSelectedDirectoryFiles
// Sort by type and alphabetically
.sort((a, b) => ((a.name.toUpperCase() < b.name.toUpperCase()) ? -1 : 1))
.filter((file) => file.name.toLowerCase().includes(this.$store.state.search.toLowerCase()));
return [...directories, ...files];
},And is replaced with
/* Get the contents of the currently selected directory */
localItems() {
const directories = this.$store.getters.getSelectedDirectoryDirectories.slice(0)
// Sort by type and alphabetically
.sort((a, b) => ((a.name.toUpperCase() < b.name.toUpperCase()) ? -1 : 1))
.filter((dir) => dir.name.toLowerCase().includes(this.$store.state.search.toLowerCase()));
const files = this.$store.getters.getSelectedDirectoryFiles.slice(0)
// Sort by type and alphabetically
.sort((a, b) => ((a.name.toUpperCase() < b.name.toUpperCase()) ? -1 : 1))
.filter((file) => file.name.toLowerCase().includes(this.$store.state.search.toLowerCase()));
return [...directories, ...files];
},The rename from items to localItems was on purpose to emphasise that this is a local representation of the data!!!
Testing Instructions
Apply the PR, run npm ci and check that the media manager is still working
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change |
| Status | New | ⇒ | Pending |
| Category | JavaScript Administration com_media NPM Change | ⇒ | JavaScript Administration com_media NPM Change Repository |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
| Title |
|
||||||
Remove gap/spacing.
Create a folder.
Open it.
See untranslated string and gap.
@dgrammatiko I can merge it for you but it's on the 4.2 branch. You will have to wait for the up-merge to get this fixed in 4.3
Maybe it is not the case in the other PR, but can you look to moving the no media message below the table? Thanks.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39709.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39709.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39709.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-27 07:51:51 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
?
|
||
Thanks!!
See text briefly displayed upon loading Media Manager.