[#39703] - Sort the Media files from the Media list.
- Closed
- 29 Jan 2023
- Medium
- Build: 4.2-dev
- # 39703
- Diff
- rajputanuj31:patch-1
User tests: Successful: Unsuccessful:
Adding sorting feature in media files
Pull Request for Issue #31347
Summary of Changes
Added some extra sorting techniques in Media files
Testing Instructions
- Go to media
- Select List View
- click on name or size or dimension or date created or date modified
Actual result BEFORE applying this Pull Request
No sorting happens
Expected result AFTER applying this Pull Request
You can sort the media files by name or size .... by clicking on respective column heading
Sorting will be first ascending and after clicking again sorting will be descending
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Before Sorting
After Sorting By Name In Descending Order
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change |
| Status | New | ⇒ | Pending |
| Category | Administration com_media NPM Change | ⇒ | Administration com_media NPM Change Repository |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Title |
|
||||||
How do you expect someone to know that they can click on a heading to sort?
How do you expect someone to know what the current sort is?
How do you expect someone to know what the current sort direction is?
Take a look at core Joomla components
@rajputanuj31 just to save you some time here the current approach that you’re following is wrong. What needs to be done here is to involve the store for remembering the users preference and then the items will adjust automatically the sorting according to the store value. That way switching from table to icons view you maintain the same sorting and also navigating around is more predictable. You could check this pr #39586 for the store parts. Also all the points that @brianteeman mentioned above should be solved…
Hello @dgrammatiko so far I have been able to implement the changes suggested by @brianteeman but I am struggling to save the preferences of the user for default behaviour. I had checked the PR you mentioned and try to understand it and some more tips will be helpful
So far my progress:
This is not correct. Take a look at core Joomla components. You should be using the exact same user interface for sorting the columns
@rajputanuj31 what I meant with the comment above was the changes here: 082ae03
The last 3 files in that commit are related to the store, the actions, the mutations and the default values. Anyways, the PR #39732 should solve the ordering issue.
@rajputanuj31 what I meant with the comment above was the changes here: 082ae03
The last 3 files in that commit are related to the store, the actions, the mutations and the default values. Anyways, the PR #39732 should solve the ordering issue.
Ok understand now. So should I close this PR now.
Ok understand now. So should I close this PR now.
Yes, please.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-29 17:14:49 |
| Closed_By | ⇒ | rajputanuj31 | |
| Labels |
Added:
?
|
||
Please update the title of this Pull Request to something more meaningful. The titles are automatically used in the changelog so it is important that they are descriptive.