Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar charvimehradu
charvimehradu
24 Jan 2023

Pull Request for Issue #38539 .

Summary of Changes

Improving the consistency of the HTML models as instructed by labeling the input tag first, as is done in the components loginĀ form.
Additionally, you can review this PR in relation to PR#39669

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2023
Category Front End com_users Language & Strings Layout Libraries Modules
avatar charvimehradu charvimehradu - open - 24 Jan 2023
avatar charvimehradu charvimehradu - change - 24 Jan 2023
Status New Pending
avatar brianteeman
brianteeman - comment - 24 Jan 2023

I have the same questions that I had on your other pull request

avatar charvimehradu charvimehradu - change - 24 Jan 2023
The description was changed
avatar charvimehradu charvimehradu - edited - 24 Jan 2023
avatar charvimehradu charvimehradu - change - 24 Jan 2023
The description was changed
avatar charvimehradu charvimehradu - edited - 24 Jan 2023
avatar charvimehradu
charvimehradu - comment - 24 Jan 2023

@brianteeman
I've responded to the questions you raised in the previous issue. I apologize for the delay; to be completely honest, I was not aware of the submit option and believed it was still awaiting your evaluation.

avatar charvimehradu charvimehradu - change - 24 Jan 2023
Title
Improving the consistency of the HTML models #38539
Improving the consistency of the HTML models
avatar charvimehradu charvimehradu - edited - 24 Jan 2023
avatar brianteeman
brianteeman - comment - 24 Jan 2023

@charvimehradu every pull request should be on a clean branch so that it only includes the changes for this issue and not all the code from your previous pull request. As you can see there are 6 files changed here but I suspect that you only meant to change one of them.

avatar charvimehradu
charvimehradu - comment - 24 Jan 2023

okay noted

avatar charvimehradu charvimehradu - close - 24 Jan 2023
avatar charvimehradu charvimehradu - change - 24 Jan 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-01-24 17:19:14
Closed_By charvimehradu
Labels Added: Language Change ?

Add a Comment

Login with GitHub to post a comment