[#39686] - Fix for fix #36345, TinyMCE, make sure iframe is fully loaded
- Fixed in Code Base
- 22 Jan 2023
- Medium
- Build: 4.2-dev
- # 39686
- Diff
- Fedik:tinymce-sort-fix5
User tests: Successful: Unsuccessful:
Pull Request for Issue #36345 for fix #24343
Summary of Changes
Make sure the script listen iframe load event only once.
Testing Instructions
Apply patch, run npm install
Create subform with editor (example in Custom HTML):
<field type="subform" name="subform" multiple="true" label="subform">
<form>
<field type="editor" name="text" label="editor" buttons="false" default="I am a text!"/>
</form>
</field>Run test in Chrome and Firefox, and Safari (if you have one).
Make sure the Article content editor works correctly.
Then add couple rows in subform and try sort them. Then watch editor content.
Actual result BEFORE applying this Pull Request
In Firefox the Article content editor realods itself, and not able to edit content.
Expected result AFTER applying this Pull Request
In all Browsers the content editor works correctly.
Content in subform editor works after sorting.
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Release Blocker
NPM Resource Changed
?
|
||
I have tested this item
Thank you!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39686.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39686.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39686.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-22 11:47:55 |
| Closed_By | ⇒ | fancyFranci | |
| Labels |
Added:
?
|
||
Thank you for fixing the fix :)
@Quy please test