? ? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
21 Jan 2023

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in file "administrator/components/com_admin/script.php" to recent changes in the 4.2-dev branch in preparation for the upcoming 4.2.7 release.

There is only one file from the debugbar dependency to be deleted on update. This is caused by PR #39594 which updated the dependency to a new version. The deleted file has been removed because it belonged to code for PHP versions older than 7.1, which are not supported anymore by the dependency and are also older than the minimum required 7.2 for J4. See this comment here in their PR: maximebf/php-debugbar#497 (comment)

Testing Instructions

Code review.

Or if you want to make a real test, update a 4.2.6 or any older 4.x version to the last 4.2-dev nightly build to get the actual result, and update a 4.2.6 or any older 4.x version to the update package built by Drone for this PR to get the expected result.

Actual result BEFORE applying this Pull Request

File "libraries/vendor/maximebf/debugbar/src/DebugBar/DataFormatter/VarDumper/SeekingData.php" is still present after the update.

Expected result AFTER applying this Pull Request

File "libraries/vendor/maximebf/debugbar/src/DebugBar/DataFormatter/VarDumper/SeekingData.php" has been deleted with the update.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 21 Jan 2023
Category Administration com_admin
avatar richard67 richard67 - open - 21 Jan 2023
avatar richard67 richard67 - change - 21 Jan 2023
Status New Pending
avatar brianteeman brianteeman - test_item - 21 Jan 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 21 Jan 2023

I have tested this item successfully on bfa638b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39684.

avatar viocassel viocassel - test_item - 21 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 21 Jan 2023

I have tested this item successfully on bfa638b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39684.

avatar richard67 richard67 - change - 21 Jan 2023
Status Pending Ready to Commit
Labels Added: ?
avatar richard67
richard67 - comment - 21 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39684.

avatar fancyFranci fancyFranci - change - 22 Jan 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-01-22 11:24:46
Closed_By fancyFranci
Labels Added: ?
avatar fancyFranci fancyFranci - close - 22 Jan 2023
avatar fancyFranci fancyFranci - merge - 22 Jan 2023
avatar fancyFranci
fancyFranci - comment - 22 Jan 2023

Thanks a lot for keeping an eye on that list :)

Add a Comment

Login with GitHub to post a comment