[#39683] - [4] PHP 8.2 Dynamic property - registeredurlparams- cache enabled
- Fixed in Code Base
- 11 Feb 2023
- Medium
- Build: 4.2-dev
- # 39683
- Diff
- alikon:patch-13
User tests: Successful: Unsuccessful:
Summary of Changes
declared $registeredurlparams
Testing Instructions
open frontend with php 8.2 with Error Reporting = maximum and cache enabled
Actual result BEFORE applying this Pull Request
Deprecated: Creation of dynamic property Joomla\CMS\Application\SiteApplication::$registeredurlparams is deprecated
Expected result AFTER applying this Pull Request
no depraction
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Labels |
Added:
PHP 8.x
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39683.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39683.
Because this variable is not used in core and I don't see a reason for it.
Because this variable is not used in core and I don't see a reason for it.
@laoneo Actually, we are using it in core. See https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/MVC/Controller/BaseController.php#L613-L629 and https://github.com/joomla/joomla-cms/blob/4.2-dev/libraries/src/Cache/Cache.php#L738
Look like we are using that variable to pass data from controller to cache. So until we find a better way to pass that data, it should not be deprecated.
Somehow I missed as I was searching for this string. Anyway, this is the wrong approach and should be done in a different way as the app object should only have member variables it actually uses and should not act as a basket for any kind of in memory storage data.
That's right, but out of scope of this PR. At least the wrong approach is more visible now.
| Labels |
Added:
?
|
||
The needs deprecation label is used to identify prs which need some followup prs for 4.3 or 5.0 with the introduction of deprecations and should not be removed. Please leve them in place @fancyFranci as I was explaining this already in maintainers chat.
Then I misunderstood your last answer that it should be refactored, which is in my opinion not the same as setting a deprecation label, but ok.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-11 13:28:49 |
| Closed_By | ⇒ | fancyFranci | |
| Labels |
Added:
?
|
||
Thank you for fixing that!
I have tested this item✅ successfully on bc242fc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39683.