? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
20 Jan 2023

Pull Request for Issue # .

Summary of Changes

  • Decouple some code from the core.js to a new file list-view.js that would be loaded in the list views
  • For the time code coexists in both files, v6 should have a way leaner core.js (renamed to something different so 100% b/c could be maintained) with only the API parts, the storage and the translation
  • touch the Grid and JGrid classes to eliminate most of the inline onclick
  • touch the searchtools layout to eliminate the onchange for the lists
  • the searchtools form changes applied only to the articles view, so check only that one!

Testing Instructions

WIP

Actual result BEFORE applying this Pull Request

  • 44 onclick
    Screenshot 2023-01-20 at 17 43 18

  • 9 onchange
    Screenshot 2023-01-20 at 17 43 37

Expected result AFTER applying this Pull Request

  • 1 onclick (from, the toolbar)
    Screenshot 2023-01-20 at 17 42 18

  • 0 onchange
    Screenshot 2023-01-20 at 17 42 32

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

1bdc493 20 Jan 2023 avatar dgrammatiko init
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jan 2023
Category Administration com_content Repository NPM Change JavaScript Layout Libraries
avatar dgrammatiko dgrammatiko - open - 20 Jan 2023
avatar dgrammatiko dgrammatiko - change - 20 Jan 2023
Status New Pending
9e08b43 20 Jan 2023 avatar dgrammatiko cs
avatar dgrammatiko dgrammatiko - change - 20 Jan 2023
Labels Added: ? NPM Resource Changed PR-4.3-dev
avatar dgrammatiko
dgrammatiko - comment - 26 Jan 2023

I will break this to more digestible PRs

avatar dgrammatiko dgrammatiko - close - 26 Jan 2023
avatar dgrammatiko dgrammatiko - change - 26 Jan 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-01-26 20:33:47
Closed_By dgrammatiko

Add a Comment

Login with GitHub to post a comment