[#39673] - Convert array to comma separated list for assigned menu ids in module edit form
- Closed
- 25 Oct 2023
- Medium
- Build: 4.2-dev
- # 39673
- Diff
- anilalci:anilalci/issue39672
User tests: Successful: Unsuccessful:
Pull Request for Issue #39672 .
Summary of Changes
Convert array to comma separated list for assigned menu ids in module edit form
Purpose : reducing the number of elements of post array
Testing Instructions
Manuel Testing;
- Create more than 1K menu items if max_input_vars is 1K
- Save a module with assigned menu items
Actual result BEFORE applying this Pull Request
You cannot save any modules because of restriction of max_input_vars
Expected result AFTER applying this Pull Request
You can save any modules although restriction of max_input_vars
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_modules JavaScript Repository NPM Change |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
?
|
||
This pull request has been automatically rebased to 4.3-dev.
This pull request has been automatically rebased to 4.4-dev.
Thank you for your work, but unfortunately I'm going to reject this PR. This is an anti-pattern which I don't want to see in Joomla. At the same time, this raises the complexity so much, that it is hard for us to maintain in the future. Considering that you would have to assign the module to close to a thousand menu items, I'm questioning the usecase for this. If you have a module that you want to manually assign to a thousand menu items, you should do this in a different way, maybe somewhere in your template or something like that. Since only checked checkboxes are transmitted in the first place, this becomes even less likely. Last but not least, I don't see how this PR fixes that issue, because it still creates all those checkboxes and when checked, still transmitts them to the server. I don't see where you are deleting all those elements before submitting the form.
Because of that, I'm closing this PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-25 08:44:29 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
bug
?
PR-4.4-dev
Removed: ? |
||
If this works then it should be extended to everywhere that we have the potential for this problem.
For testing purposes its probbly best to use https://github.com/nikosdion/overload to generate the menu items etc