Feeling Lucky
?
PR-4.3-dev
[#39670] - Converts the fields plugins to service providers
- Fixed in Code Base
- 4 Feb 2023
- Medium
- Build: 4.3-dev
- # 39670
- Diff
- Digital-Peak:provider/fields
User tests: Successful: Unsuccessful:
Summary of Changes
Converts the fields plugins to service providers.
Testing Instructions
Create various custom fields of all types and edit an article in the back end.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
carlitorweb
- comment
- 25 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39670.
viocassel
- comment
- 26 Jan 2023
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39670.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 26 Jan 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39670.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-02-04 05:23:41 |
| Closed_By | ⇒ | obuisard |
@laoneo Could you fix the PHPCS errors reported in drone? https://ci.joomla.org/joomla/joomla-cms/61055/1/8 It seems they are all of the same kind "Space before opening parenthesis of function call prohibited", and i think it's mainly where you create new object like e.g.
new SQL (, which should benew SQL(here https://github.com/joomla/joomla-cms/pull/39670/files#diff-354ab32e246eaeee8352a92c417bd52e09007c8ca9c7f583687af46150cec92eR38 .