[#39669] - Login Page & Login Module consistency [4.2.6 Bugs]
- Closed
- 24 Jan 2023
- Medium
- Build: 4.2-dev
- # 39669
- Diff
- charvimehradu:test#39641
User tests: Successful: Unsuccessful:
Pull Request for Issue #39641.
Summary of Changes
- Changes made in the Login Page.
- Added the icon user image. (1A)
- Changed the "forgot your password?" and "forgot your username?" buttons to a link to show consistency. (1B)
- Assigned 100% width to the "Log In" button. (1C)
- Assigned placeholders to both username and password fields. (2A)
- Changes made in the Login Module.
- Gave titles to both the input fields of "Username *" and "Password *". (3A)
Testing Instructions
Head to the login page on the front end and login module.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End com_users Layout Libraries Modules |
| Status | New | ⇒ | Pending |
No need to add the comments. You can just explain them in a reply to the comments
okay thankyou
Hi guys,
thank you. Few things are "missing":
1B - "...buttons to a link to show consistency..." = From my point of view would be better the reverse, Links to Buttons. They would be more consistent with the Web Authentication button.
2B - the "Login Module > Display Labels: Yes / No" setting option is missing in the Login Page menu item. Would be good to add it.
3B - in the Login Page menu item (but also in the Backend Administartor Login), if I click into the Username / Password field and then I click out the field without to complete them, the field is red marked with: "Please fill in this field".
This check is missing in the Login Module. Please, Can you confirm and add it ?
3C - "Login Module > Display Labels: Yes" = the icon-user and icon-eye disappear. Please, Can you confirm the bug ?
4 - Language string:
- COM_USERS_LOGIN_REMEMBER_ME: Remember me
- MOD_LOGIN_REMEMBER_ME: Remember Me
- (and maybe) JGLOBAL_REMEMBER_ME: Remember me
Would be good to have all as "Remember me" OR "Remember Me"
5 - Would be good to apply the same standard (all these points) also to the Backend Administartor Login
| Labels |
Added:
?
|
||
| Category | Front End com_users Layout Libraries Modules | ⇒ | Front End com_users Language & Strings Layout Libraries Modules |
Sorry but this is completely wrong and I hope that you can now see why. I had hopes that my questions would have prompted you to look again at the code.
You should test the code before you submit it. Then you would see the errors.
You're correct. I apologize for my mistakes and for taking up your time, and I appreciate that you correctly pointed them out because I learned a lot. I intend to fix the code and come up with a better solution to offer you in the near future.
This should be closed and the original issue re-opened
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-24 17:32:00 |
| Closed_By | ⇒ | charvimehradu | |
| Labels |
Added:
Language Change
|
||
@charvimehradu thank you for your contribution! Don't let discourage you. Joomla is a huge system and every change can have side effects everywhere.
Thanks @brianteeman for testing.
Oh, yes. It has made me learn more so I am more grateful than discouraged
Hey, @brianteeman
After reading your review comments, I believe I can add a few comments and make a few minor adjustments to the code to make it easier to read. I wanted to know if you thought there was a need for it. If so, I intend to create a draught of this pull request and then re-push the changes.