?

User tests: Successful: Unsuccessful:

avatar Harmageddon
Harmageddon
25 Jul 2014

Hi everyone!

This PR tries to adapt changes that were made to the 3.x version of the emailcloak plugin. These changes fixed several bugs, so they should be implemented in 2.5.x, too. One of these bugs is #3956, which was fixed for 3.x yesterday.
As I don't have much time to test this PR right now, I ask you to test this thoroughly, so that we don't have to release three more versions until mailcloaking works again. I'll test the PR tonight or tomorrow by myself. But because this fixes some major and urgent bugs, I'm proposing it only rarely tested.

Testing instructions

Please test all variants to use this plugin (every of them with javascript enabled and disabled):
1. <a href="http://mce_host/ourdirectory/email@example.org">email@example.org</a>
2. <a href="http://mce_host/ourdirectory/email@example.org">text</a>
3. <a href="mailto:email@example.org">email@example.org</a>
4. <a href="mailto:email@example.org">text</a>
5. <a href="mailto:email@example.org"><img src="..." /></a>
6. <a href="mailto:email@example.org?subject=Text">email@example.org</a>
7. <a href="mailto:email@example.org?subject=Text">text</a>
8. <a href="mailto:email@example.org?subject=Text"><img src="..." /></a>
9. plain email@example.org
...and please test all of these variants with attributes, such as class and style attributes before and after the href attribute.

avatar Harmageddon Harmageddon - open - 25 Jul 2014
avatar infograf768
infograf768 - comment - 26 Jul 2014

I have corrected _addAttributesToEmail in 3.3.3
This PR should include these changes

avatar Harmageddon
Harmageddon - comment - 26 Jul 2014

@infograf768
Thank you! Updated the PR.

avatar infograf768
infograf768 - comment - 31 Jul 2014

Please test this
#4041

and add to this patch after testing.

avatar infograf768
infograf768 - comment - 2 Aug 2014

Hello, I have merged #4041 in staging.

Can you update your PR?
Here is a fully modified emailcloak.php:
http://info-graf.fr/ftpfolder/emailcloak.php.zip

avatar infograf768
infograf768 - comment - 4 Aug 2014

Please see #4069
It is included in the zip above

avatar zero-24
zero-24 - comment - 4 Aug 2014

@test @infograf768 successful

@Harmageddon can you add the file: http://info-graf.fr/ftpfolder/emailcloak.php.zip to your patch here?

avatar Harmageddon
Harmageddon - comment - 5 Aug 2014

@infograf768
I've tested and added your changes. Thank you!

Meanwhile, I'm thinking about simplifying this whole thing and breaking it down to 3-5 regular expressions...

avatar infograf768 infograf768 - change - 5 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-05 10:59:19
avatar infograf768 infograf768 - close - 5 Aug 2014
avatar infograf768
infograf768 - comment - 5 Aug 2014

Thanks. Solved for now and next releases.
Welcome a totaly refactored mailcloak as this is indeed getting complex.

Add a Comment

Login with GitHub to post a comment