User tests: Successful: Unsuccessful:
Hi everyone!
This PR tries to adapt changes that were made to the 3.x version of the emailcloak plugin. These changes fixed several bugs, so they should be implemented in 2.5.x, too. One of these bugs is #3956, which was fixed for 3.x yesterday.
As I don't have much time to test this PR right now, I ask you to test this thoroughly, so that we don't have to release three more versions until mailcloaking works again. I'll test the PR tonight or tomorrow by myself. But because this fixes some major and urgent bugs, I'm proposing it only rarely tested.
Please test all variants to use this plugin (every of them with javascript enabled and disabled):
1. <a href="http://mce_host/ourdirectory/email@example.org">email@example.org</a>
2. <a href="http://mce_host/ourdirectory/email@example.org">text</a>
3. <a href="mailto:email@example.org">email@example.org</a>
4. <a href="mailto:email@example.org">text</a>
5. <a href="mailto:email@example.org"><img src="..." /></a>
6. <a href="mailto:email@example.org?subject=Text">email@example.org</a>
7. <a href="mailto:email@example.org?subject=Text">text</a>
8. <a href="mailto:email@example.org?subject=Text"><img src="..." /></a>
9. plain email@example.org
...and please test all of these variants with attributes, such as class and style attributes before and after the href attribute.
@infograf768
Thank you! Updated the PR.
Hello, I have merged #4041 in staging.
Can you update your PR?
Here is a fully modified emailcloak.php:
http://info-graf.fr/ftpfolder/emailcloak.php.zip
@test @infograf768 successful
@Harmageddon can you add the file: http://info-graf.fr/ftpfolder/emailcloak.php.zip to your patch here?
@infograf768
I've tested and added your changes. Thank you!
Meanwhile, I'm thinking about simplifying this whole thing and breaking it down to 3-5 regular expressions...
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-05 10:59:19 |
Thanks. Solved for now and next releases.
Welcome a totaly refactored mailcloak as this is indeed getting complex.
I have corrected _addAttributesToEmail in 3.3.3
This PR should include these changes