? ? Success

User tests: Successful: Unsuccessful:

avatar Harmageddon
Harmageddon
25 Jul 2014

Description

This enables protostar to display nav-pills menus with two or more levels of submenus.

Testing instructions

  1. Create a menu with more than two levels in backend or use one of the ones provided with sample data. In my pictures, I used the "About Joomla" menu from sample data.
  2. Create a menu module
    • Type: Menu
    • Position: position-1
    • Select Menu: Your menu from step 1
    • Start level: 1
    • End level: all
    • Show Sub-menu Items: Yes
  3. Save / publish the module.
  4. Set Protostar as your frontend template.
  5. Hover over the menu items in frontend. The first level of sub-items will be shown, but nothing beyond that.
  6. Apply the PR
  7. Now, all levels should be accessible in the dropdown menu. JoomlaCode item: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32092 Old PR: #2073
avatar Harmageddon Harmageddon - open - 25 Jul 2014
avatar brianteeman brianteeman - change - 8 Aug 2014
Labels Added: ?
avatar zero-24
zero-24 - comment - 9 Aug 2014

thanks @Harmageddon I have test this successful. Moving to RFR (Ready for review)

avatar infograf768
infograf768 - comment - 10 Aug 2014

Have you checked with RTL languages?

avatar zero-24
zero-24 - comment - 10 Aug 2014

@infograf768 confirmed. The dropdown is also in RTL on the left side. @Harmageddon will have a look on it.

avatar Harmageddon
Harmageddon - comment - 10 Aug 2014

@infograf768 I knew I forgot something... Thank you!
Indeed, RTL support was missing. Just added a new commit, I hope I changed the right file. This file is used in Isis, too, but the lines added by me shouldn't have any impact on Isis, as far as I see.

Please test again for RTL and LTR! Tracker status is back to pending.

avatar brianteeman
brianteeman - comment - 10 Aug 2014

Dont you need to update /administrator/templates/isis/less/template-rtl.less ???

avatar Harmageddon
Harmageddon - comment - 10 Aug 2014

@brianteeman I want to change the submenus for Protostar, not for Isis. Not sure if I misunderstood you, but why should I edit Isis files then?

avatar brianteeman
brianteeman - comment - 10 Aug 2014

@Harmageddon I said that because you are editing administrator/templates/isis/css/template-rtl.css

avatar Harmageddon
Harmageddon - comment - 10 Aug 2014

@brianteeman Yes, that's what I meant with my comment.
I changed bootstrap-rtl.less, which is compiled to bootstrap-rtl.css, which is included in Protostar for RTL languages. But bootstrap-rtl.less is included in isis/less/template-rtl.less, so isis/css/template-rtl.css changes, too.
However, this shouldn't have any effect on Isis, because there is no .navigation element in Isis, as far as I see. I'm adding some useless lines to isis/css/template-rtl.css, but I don't see any other place where RTL definitions for Protostar could go.

avatar brianteeman
brianteeman - comment - 10 Aug 2014

What I am saying is that your pull request IS editing the isis rtl css file so if tht is correct you need to edit the matching less file

avatar Harmageddon
Harmageddon - comment - 10 Aug 2014

@brianteeman
My PR is editing the isis rtl css file by running generatecss.php, compiling all less files. Because isis/less/template-rtl.less imports /media/jui/less/bootstrap-rtl.less, the matching css file is changed by this generation, because I changed bootstrap-rtl.less.

avatar zero-24
zero-24 - comment - 13 Aug 2014

@Harmageddon
Please have a look here:
submenu_protostar_rtl

Can we move the dropdown on RTL to the right so that all submenus can be show?

avatar roland-d
roland-d - comment - 15 Aug 2014

@test Works as described testing on Protostar.

avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 19 Sep 2014
Category Modules Templates (site)
avatar trangredweb
trangredweb - comment - 17 Oct 2014

@test
Working as describe on protostar, just css menu, it will display perfect.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3966.

avatar trangredweb trangredweb - test_item - 17 Oct 2014 - Tested successfully
avatar catanet
catanet - comment - 17 Oct 2014

@test
Environment: Joomla! 3.3.6 with test data loaded
Result: tested successfully, the bubbles of the sub levels are displayed correctly.

Note: there are two issues: 1. the title of the module doesn't appear; 2. the alignment of the menu is vertical, not horizontal (see attached screenshot).

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3966.

avatar catanet
catanet - comment - 17 Oct 2014

screen shot 2014-10-17 at 04 27 45

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3966.

avatar catanet catanet - test_item - 17 Oct 2014 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 Oct 2014

@catanet They are unrelated issues. This module position in this template is coded not to display a title and you need to apply a class suffix of nav_pills to display the top level correctly iirc

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3966.

avatar KISS-Web-Design
KISS-Web-Design - comment - 17 Oct 2014

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:

chris.jones-gill@ntlworld.com
Domain kisswebdesign.co.uk has exceeded the max emails per hour (101/100 (101%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------
Received: from o6.sgmail.github.com ([192.254.113.101]:30220)
by duffman.enixns.com with smtps (TLSv1:DHE-RSA-AES128-SHA:128)
(Exim 4.82)
(envelope-from )
id 1Xf4HB-002gZb-Cm
for chris.jones-gill@kisswebdesign.co.uk; Fri, 17 Oct 2014 10:56:49 +0100
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sgmail.github.com;
h=from:reply-to:to:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=smtpapi; bh=ar0fffEKip1KpHIgNZMvDUsuWeg=; b=uUe08b+1Ldw6evPuAe
jJj7xU5Zg+aWSWLBXnLXk6M9+09ZY59zixFIgsFOCGLqnW0pIDdVMmRuiPtkRFnq
BJKs15KxfTXH8AKk0jdEKkoO5CX1khtJGJLOOAoxQojzFCi+vBfHX6NwhMVwP4zh
2ER6lWmBXAuGUqcGXugeQureg=
Received: by filter0012p1mdw1.sendgrid.net with SMTP id filter0012p1mdw1.15677.5440E7D9A
2014-10-17 09:56:43.743169821 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16])
by ismtpd-034 (SG) with ESMTP id 1491d89b220.4c23.136bc
for chris.jones-gill@kisswebdesign.co.uk; Fri, 17 Oct 2014 09:56:43 +0000 (UTC)
Date: Fri, 17 Oct 2014 02:56:42 -0700
From: Brian Teeman notifications@github.com
Reply-To: joomla/joomla-cms reply@reply.github.com
To: joomla/joomla-cms joomla-cms@noreply.github.com
Message-ID:
In-Reply-To:
References:
Subject: Re: [joomla-cms] [#32092] [feature] Nested submenus for top menu in
protostar (#3966)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5440e7daba70e_11eb3fabb2b392bc106662a";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: brianteeman
X-GitHub-Recipient: KISS-Web-Design
List-ID: joomla/joomla-cms
List-Archive: https://github.com/joomla/joomla-cms
List-Post: reply@reply.github.com
List-Unsubscribe: unsub+i-38740734-c8887dbf4c25e1052e6697435ef6121891d1d934-1520943@reply.github.com,
https://github.com/notifications/unsubscribe/1520943__eyJzY29wZSI6Ik5ld3NpZXM6TXV0ZSIsImV4cGlyZXMiOjE3MjkxNTkwMDIsImRhdGEiOnsiaWQiOjM3OTg3ODIzfX0=--73ea324a4390fe72b764d980a4b854921fcb7063
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: chris.jones-gill@kisswebdesign.co.uk
X-SG-EID: VbUrg+PV5gtDPTDYRRAOR3pJ+t6F3RV8HmCrRNfs1fiYkdeFG2H8FQPjh3b+WBYR91S/6X7dFLf3+bve9UgrdIfC39zmSnCsB+TS853AEJdFus4d9YJZgUFHr1j6lbsI7yinWKlQQmDjL5uinYzmj6UMZfpsl2nDou0y9ADC8UNUIucJKK97H3JMo7463Gkw
X-enixltd-MailScanner-Information: Please contact the ISP for more information
X-enixltd-MailScanner-ID: 1Xf4HB-002gZb-Cm
X-enixltd-MailScanner: Found to be clean
X-enixltd-MailScanner-SpamCheck: not spam, SpamAssassin (not cached,
score=-3.106, required 5, autolearn=not spam, BAYES_00 -1.90,
DKIM_SIGNED 0.10, DKIM_VALID -0.10, HTML_IMAGE_ONLY_16 1.09,
HTML_MESSAGE 0.00, RCVD_IN_DNSWL_MED -2.30, URIBL_BLOCKED 0.00)
X-enixltd-MailScanner-From: bounces+848413-bc12-chris.jones-gill=kisswebdesign.co.uk@sgmail.github.com
X-Spam-Status: No

----==_mimepart_5440e7daba70e_11eb3fabb2b392bc106662a
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit

@catanet They are unrelated issues. This module position in this template is coded not to display a title and you need to apply a class suffix of nav_pills to display the top level correctly iirc

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3966.


Reply to this email directly or view it on GitHub:
#3966 (comment)
----==_mimepart_5440e7daba70e_11eb3fabb2b392bc106662a
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit

@catanet They are unrelated issues. This module position in this template is coded not to display a title and you need to apply a class suffix of nav_pills to display the top level correctly iirc

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3966.


Reply to this email directly or view it on GitHub.

----==_mimepart_5440e7daba70e_11eb3fabb2b392bc106662a--

avatar mtmeyrick mtmeyrick - test_item - 17 Oct 2014 - Tested successfully
avatar brianteeman
brianteeman - comment - 18 Oct 2014

Multiple good tests - setting to RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3966.

avatar brianteeman brianteeman - change - 18 Oct 2014
Status Pending Ready to Commit
avatar Bakual
Bakual - comment - 24 Oct 2014

Merged into staging. Thanks!

avatar Bakual Bakual - close - 24 Oct 2014
avatar Bakual Bakual - change - 24 Oct 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-10-24 14:13:22

Add a Comment

Login with GitHub to post a comment