Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#39659] - [4.3][bug] Refresh list of parent menu items after menu selection has been changed

? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
17 Jan 2023

Pull Request for Issue #38792

Summary of Changes

This patch correctly refreshes the list of available parent menu item after the actual menu assignment has been changed. This prevents an incorrect configuration (parent menu item selected which does not belong to the selected menu) being stored.

Testing Instructions

  • Creata a J4 site with at least two menus and at least one menu item each
  • Change the menu assignment of one menu item
  • Check the available options in the parent menu item select

Actual result BEFORE applying this Pull Request

Parent menu select shows menu items of the old menu assignment.

Expected result AFTER applying this Pull Request

Parent menu select shows menu items of the new menu assignment.

Link to documentations

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jan 2023
Category ⇒ Administration com_menus JavaScript Repository NPM Change
avatar SniperSister SniperSister - open - 17 Jan 2023
avatar SniperSister SniperSister - change - 17 Jan 2023
Status New ⇒ Pending
avatar SniperSister SniperSister - change - 17 Jan 2023
Title
…
Refresh list of parent menu items after menu selection has been changed
[4.3][bug] Refresh list of parent menu items after menu selection has been changed
avatar SniperSister SniperSister - edited - 17 Jan 2023
avatar SniperSister SniperSister - change - 17 Jan 2023
The description was changed
avatar SniperSister SniperSister - edited - 17 Jan 2023
avatar SniperSister SniperSister - change - 17 Jan 2023
The description was changed
avatar SniperSister SniperSister - edited - 17 Jan 2023
avatar SniperSister SniperSister - change - 17 Jan 2023
Labels Added: NPM Resource Changed PR-4.3-dev
avatar chmst chmst - test_item - 18 Jan 2023 - Tested successfully
avatar chmst
chmst - comment - 18 Jan 2023

I have tested this item ✅ successfully on ad1c257

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39659.

avatar viocassel viocassel - test_item - 18 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 18 Jan 2023

I have tested this item ✅ successfully on ad1c257

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39659.

avatar Quy Quy - change - 18 Jan 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 18 Jan 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39659.

avatar obuisard obuisard - change - 19 Jan 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-01-19 00:48:50
Closed_By ⇒ obuisard
Labels Added: ?
avatar obuisard obuisard - close - 19 Jan 2023
avatar obuisard obuisard - merge - 19 Jan 2023
avatar obuisard
obuisard - comment - 19 Jan 2023

Thank you David @SniperSister for the bug fix!

Add a Comment

Login with GitHub to post a comment