[#39647] - Do not hardcode the media manager API url to select an image
- Fixed in Code Base
- 20 Jan 2023
- Medium
- Build: 4.3-dev
- # 39647
- Diff
- Digital-Peak:mm/select-api-url-config
User tests: Successful: Unsuccessful:
Summary of Changes
The media manager is loading their API urls from the JS config store, expect when selecting files in the media form field. This pr extends the media manager the way that the API url is passed to the media field. For backwards compatibility it does a fallback to the old url when it doesn't exist already. This situation can be for older overrides.
@dgrammatiko can you review?
Testing Instructions
Select an intro or full image in the images field.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Layout Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
PR-4.3-dev
|
||
Out of curiosity, why did you went with a new entry in the storageOption instead of reusing the existing media-picker key?
@laoneo The JavaScript linter complains: https://ci.joomla.org/joomla/joomla-cms/60937/1/29
Out of curiosity, why did you went with a new entry in the storageOption instead of reusing the existing
media-pickerkey?
Because the old code which adds the entry makes a check if it doesn't exist and then it adds it otherwise not. Using that one makes it unnecessary complex.
Makes sense, thanks
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39647.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39647.
@dgrammatiko I just see with this PR the TODO comment: // @TODO add this attribute to the field in order to use it for all media types in the layout file. Can be possible this be related with the solution of the issue #35088 ?
Yup, that's the missing part
I wonder if is better insert the types allowed from the options in com_media, instead of hardcode it like this.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39647.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39647.
I wonder if is better insert the types allowed from the options in com_media, instead of hardcode it like this.
@carlitorweb I'm not sure if the MediaHelper returns the list needed here (probably it does because I think I used it in the core media field). Also the implementation should be fairly easy, remove the hardcoded types, add a subform field list for the types (default value to images for b/c). The only thing that might need some thinking is the layout (to keep it 100% b/c), my personal idea would be to keep the default layout for images and add another when there are more options selected (the list field should be multiple, meaning the value could be any combination between images, audios, videos, documents).
@dgrammatiko thank for the hints. I will work with that, and see if I get it done.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39647.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-20 00:16:20 |
| Closed_By | ⇒ | obuisard |
I have tested this item✅ successfully on 2fe8e36
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39647.