? No Code Attached Yet
avatar joomleb
joomleb
16 Jan 2023

Hi guys,
PHP 7.4.33 + Joomla 4.2.6 > here the test page
(Edited) About the Login Page menu item & Login Module, it is not so important what you decide, but the important thing is that there is consistency:

1 - Same Layout on both
1A - the "icon-user", to add or not ?
1B - Forgot Username / Forgot Password = From my point of view would be better the reverse, Links to Buttons. They would be more consistent with the Web Authentication button.
1C - "Log in" button, to have it 100% width also in the Login page ?
Here an image for you:
Login-Page-Module

2 - the Login Page
2A - Username / Password fields are missing placeholders
2B - the "Login Module > Display Labels: Yes / No" setting option is missing in the Login Page menu item. Would be good to add it.

3 - the Login Module
3A - the Username / Password fields Labels are not signed with the mandatory "*"
3B - in the Login Page menu item (but also in the Backend Administartor Login), if I click into the Username / Password field and then I click out the field without to complete them, the field is red marked with: "Please fill in this field".
This check is missing in the Login Module. Please, Can you confirm and add it ?
This check is missing in the Login Module. Please, Can you confirm?
3C - "Login Module > Display Labels: Yes" = the icon-user and icon-eye disappear. Please, Can you confirm the bug ?

4 - Language string:

COM_USERS_LOGIN_REMEMBER_ME: Remember me
MOD_LOGIN_REMEMBER_ME: Remember Me
(and maybe) JGLOBAL_REMEMBER_ME: Remember me
Would be good to have all as "Remember me" OR "Remember Me"
5 - Would be good to apply the same standard (all these points) also to the Backend Administartor Login

5 - Would be good to apply the same standard (all these points) also to the Backend Administartor Login

avatar joomleb joomleb - open - 16 Jan 2023
avatar joomleb joomleb - change - 16 Jan 2023
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jan 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 16 Jan 2023
avatar joomleb joomleb - change - 16 Jan 2023
The description was changed
avatar joomleb joomleb - edited - 16 Jan 2023
avatar joomleb joomleb - change - 16 Jan 2023
The description was changed
avatar joomleb joomleb - edited - 16 Jan 2023
avatar chmst chmst - change - 18 Jan 2023
Labels Added: good first issue
avatar chmst chmst - labeled - 18 Jan 2023
avatar chmst
chmst - comment - 18 Jan 2023

Thanks for your contribution, very attentive.

Would be good to don't waste language strings for the same things in the same site, so, at least for the "Remember me" would be good to use the same language string.

It is no waste, it has technical reasons.

Also not sure if a module must have the same appearance as a view. In general modules take less place in the sidebars than component views and therefore are designed for another purpose, No user will see a screen with both login variants at the same time.

avatar chmst chmst - change - 18 Jan 2023
Labels Removed: good first issue
avatar chmst chmst - unlabeled - 18 Jan 2023
avatar richard67 richard67 - close - 20 Jan 2023
avatar richard67
richard67 - comment - 20 Jan 2023

Closing as having a pull request. Please test #39669 .

avatar richard67 richard67 - change - 20 Jan 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-01-20 07:43:32
Closed_By richard67
avatar joomleb
joomleb - comment - 20 Jan 2023

Hi guys,
thank you!

@chmst :

"...Also not sure if a module must have the same appearance as a view..." = We are agree, but we are not speaking about "colors" / "layout", we are speaking about "features"

"...In general modules take less place in the sidebars than component views and therefore are designed for another purpose,.." = Sorry, but in this case the Login feature is the Login feature, does not matter if in a page (more space) or through a module (less page).
Also the "Backend Administartor Login" should be considered.

"...No user will see a screen with both login variants at the same time..." = That has nothing to do with it. I should do a treatise on applied psychology and marketing to be able to explain myself. Perhaps the simplest way is to say that "user friendly" means above all doing the same thing, from a thousand different points, in the same way (there are "expectation" issues to consider). It's more or less the same goal to reach when we talk about "responsive": everything can change without changing anything.
I remain available (friendly) to explain myself better with interesting scientific research in hand...

avatar joomleb joomleb - change - 24 Jan 2023
The description was changed
avatar joomleb joomleb - edited - 24 Jan 2023
avatar joomleb
joomleb - comment - 24 Jan 2023

@richard67
I edited the original post here to better define the report.
As far as I see this is not solved and it should be re-opened, thank you

avatar charvimehradu
charvimehradu - comment - 1 Feb 2023

Regarding this issue, I wanted to talk about a few things and get some advice on 1A,2A and 2B

Observation: If we select the display labels to icons and not text option, the login module's user icon picture will appear (there is no such icon present for the login menu and the backend login page)

Suggestion: The display label option, which is currently only available for the login module, provides us the choice of displaying text or icons. I believe the display labels option should change from text/icon to text/placeholders instead, and the password hide/show icon should always be present. When we select the text option, it shows heading to the input field while the placeholders still remain there, which is meaningless.

I wanted to know whether it would be okay and make sense for this change.

avatar drmenzelit
drmenzelit - comment - 10 Feb 2023

Reopening because the PR #39787 doesn't include all points mentioned here

avatar drmenzelit drmenzelit - change - 10 Feb 2023
Status Closed New
Closed_Date 2023-01-20 07:43:32
Closed_By richard67
avatar drmenzelit drmenzelit - reopen - 10 Feb 2023
avatar Hackwar Hackwar - change - 23 Feb 2023
Labels Added: ?
avatar Hackwar Hackwar - labeled - 23 Feb 2023
avatar joomleb
joomleb - comment - 16 Oct 2023

Hi guys,
It would be good.to solve this with the J5 release.

I cannot help with code, but I remain available for testings...

Add a Comment

Login with GitHub to post a comment